Bug 14773 - Rename an incorrect variable in solarisacl_sys_acl_set_fd()
Summary: Rename an incorrect variable in solarisacl_sys_acl_set_fd()
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.14.6
Hardware: All Solaris
: P5 normal (vote)
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-30 18:47 UTC by David Gajewski
Modified: 2021-08-06 17:20 UTC (History)
1 user (show)

See Also:

Attachments
1 line patch switching variable names (361 bytes, patch)
2021-07-30 18:47 UTC, David Gajewski 		no flags Details
git-am fix for master and 4.15.rc2. (966 bytes, patch)
2021-08-02 21:41 UTC, Jeremy Allison 		slow: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Gajewski 2021-07-30 18:47:01 UTC 
Created attachment 16705 [details]
1 line patch switching variable names

In s3/modules/vfs_solarisacl.c, under solarisacl_sys_acl_set_fd() there was a variable named "default_acl" in earlier versions of samba (example 4.13.10) which occured 4 times.  In the upcoming release it has been renamed to "other_acl".  However in the current stable release (4.14.6) only 3 of the 4 mentions were changed, which will result in a compile error.

The commit was "vfs_solarisacl: add support for SMB_ACL_TYPE_DEFAULT in solarisacl_sys-acl_set_fd()" that made the partial change.

A patch is attached.
Comment 1 Jeremy Allison 2021-08-02 21:41:30 UTC 
Created attachment 16710 [details]
git-am fix for master and 4.15.rc2.

Ralph can you review. No ci needed as this is only a Solaris fix. Applies for master and 4.15.rc2.
Comment 2 Jeremy Allison 2021-08-02 21:42:11 UTC 
David, can you confirm you're OK with your "Signed-off-by:" added ?
Comment 3 David Gajewski 2021-08-03 17:07:54 UTC 
Confirmed -  I'm OK with "Signed-off-by:" addition.
Comment 4 Ralph Böhme 2021-08-06 16:29:08 UTC 
Comment on attachment 16710 [details]
git-am fix for master and 4.15.rc2.

Lgtm, pushed to autobuild.
Comment 5 Samba QA Contact 2021-08-06 17:20:02 UTC 
This bug was referenced in samba master:

069d23f0a717ac520560f853a5f34fd4fd92d220