Bug 14717 - talloc_unlink() is very slow with many siblings and a reference
Summary: talloc_unlink() is very slow with many siblings and a reference
Status: NEW
Alias: None
Product: TALLOC
Classification: Unclassified
Component: libtalloc (show other bugs)
Version: 2.1.10
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Simo Sorce
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 14710
  Show dependency tree / graph
 
Reported: 2021-05-25 10:51 UTC by Andrew Bartlett
Modified: 2021-05-25 10:55 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2021-05-25 10:51:09 UTC 
In _tc_free_children_internal() there is a call to talloc_parent_chunk() if there are references.

If this can be moved to after the _tc_free_children_internal() fails, then this call is much faster if there are (eg) 100,000 siblings, as can happen in python due to large number of pytalloc objects.
Comment 1 Andrew Bartlett 2021-05-25 10:54:50 UTC 
Bug #14710 needs this otherwise the test is just a CPU spinner