Bug 1466 - connections.tdb entry for total_smbds not decremented on child panics
Summary: connections.tdb entry for total_smbds not decremented on child panics
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: File Services (show other bugs)
Version: 3.0.5
Hardware: All All
: P3 normal
Target Milestone: none
Assignee: Gerald (Jerry) Carter (dead mail address)
QA Contact: Samba QA Contact
Depends on:
Reported: 2004-06-18 17:53 UTC by Herb Lewis
Modified: 2005-08-24 10:22 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Herb Lewis 2004-06-18 17:53:50 UTC
If you set max smbd processes in the smb.conf file the connections.tdb will
contain a counter for the total_smbds that is used to see if you have exceeded
the max allowed. If a child smbd exits normally this value is decremented by 
decrement_smbd_process_count. However, if the process crashes, this does not
happen and the total_smbds will slowly climb to the point where new 
connections may be denied when you have not exceeded the value.

We need to change the method of decrementing and maybe let the master smbd
do this when the child process exits by catching SIGCHLD.
Comment 1 Herb Lewis 2004-06-18 18:28:48 UTC
When smbd is not being run from inetd the master smbd should probably 
delete the old connections.tdb. That would have allowed this bug to 
be worked around by stopping and restarting smbd.
Comment 2 Gerald (Jerry) Carter (dead mail address) 2004-07-06 10:38:15 UTC
Herb,  I thought I already fixed this.  Did you look at smb_panic2() ?
Comment 3 Herb Lewis 2004-07-08 12:05:44 UTC
I was running 3.0.2a and it didn't have that function. I'll test the
latest version :-)
Comment 4 Gerald (Jerry) Carter (dead mail address) 2005-02-05 07:54:25 UTC
Comment 5 Gerald (Jerry) Carter (dead mail address) 2005-02-07 09:47:45 UTC
originally against 3.0.5pre1 (which became 3.0.6pre1 due to security release))
Comment 6 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:22:53 UTC
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.