Bug 14609 - smb.conf min protocol documentation lists incorrect defaults
Summary: smb.conf min protocol documentation lists incorrect defaults
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 4.11.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Björn Jacke
QA Contact: Samba Documentation QA Contact~
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-08 14:57 UTC by Coan Dillahunty
Modified: 2021-01-14 11:36 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Coan Dillahunty 2021-01-08 14:57:41 UTC
Hello, the smb.conf documentation (https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html) for two values is incorrect based on the change to disable SMB1 in 4.11.

The following two values have incorrect default values set:
server min protocol
client min protocol

Both say that the default is "CORE" when in actuality the default as of 4.11 is "SMB2_02"

The samba 4.11 release notes (https://www.samba.org/samba/history/samba-4.11.0.html) record that these defaults have been changed to "SMB2_02" and the smb.conf documentation should be updated to reflect that.
Comment 1 Ralph Böhme 2021-01-08 15:11:38 UTC
You're looking at an older version. The authoritative source has been adjusted with 840b8501b43695802d78726409b69afb4976166a.
Comment 2 Coan Dillahunty 2021-01-08 15:16:59 UTC
The source has been adjusted, but the samba online documentation hasn't. This page is still current and is incorrect:

https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html
Comment 3 Coan Dillahunty 2021-01-08 15:18:35 UTC
The version based html documentation also lists the incorrect default values. For example:

https://www.samba.org/samba/docs/4.12/man-html/smb.conf.5.html
Comment 4 Coan Dillahunty 2021-01-08 15:18:35 UTC
The version based html documentation also lists the incorrect default values. For example:

https://www.samba.org/samba/docs/4.12/man-html/smb.conf.5.html
Comment 5 Ralph Böhme 2021-01-08 15:24:35 UTC
Björn, can you update the html pages with correct version?

@Coan, thanks for bringing this up!
Comment 6 Björn Jacke 2021-01-12 11:12:24 UTC
I don't see a different between the man page and the html docs. Please tell me exactly which versions and which exact parameters need which fixes in the html docs.
Comment 7 Björn Jacke 2021-01-14 11:36:51 UTC
now I see, "current" was still pointing to 4.10. Fixed.