Bug 14586 - The heimdal build fails if flex isn't installed
Summary: The heimdal build fails if flex isn't installed
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.13.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2020-11-27 10:11 UTC by Andreas Schneider
Modified: 2021-04-20 11:11 UTC (History)
3 users (show)

See Also:

patch from master backported to 4.14 (only) (3.25 KB, patch)
2021-04-18 18:47 UTC, Andrew Bartlett
dbagnall: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2020-11-27 10:11:44 UTC
If I run ./configure.developer and then make and don't have flex installed, I get the following error:

Build failed                                                                                  
Traceback (most recent call last):                                                            
  File "/home/asn/workspace/projects/samba/third_party/waf/waflib/Context.py", line 452, in cmd_and_log
    ret, out, err = Utils.run_process(cmd, kw, cargs)             
  File "/home/asn/workspace/projects/samba/third_party/waf/waflib/Utils.py", line 992, in run_process
    return run_prefork_process(cmd, kwargs, cargs)
  File "/home/asn/workspace/projects/samba/third_party/waf/waflib/Utils.py", line 927, in run_prefork_process
    raise Exception(trace)
Exception: ['--noline', '../../source4/heimdal/lib/com_err/lex.l']
Traceback (most recent call last):                                                                                                                                                           
  File "<string>", line 37, in run
  File "/usr/lib64/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,               
  File "/usr/lib64/python3.8/subprocess.py", line 1702, in _execute_child                                                                                                                    
    raise child_exception_type(errno_num, err_msg, err_filename) 
FileNotFoundError: [Errno 2] No such file or directory: '--noline'

configure should check for flex and abort if it isn't installed in heimdal case.
Comment 1 Samba QA Contact 2021-03-29 02:13:12 UTC
This bug was referenced in samba master:

Comment 2 Andrew Bartlett 2021-04-18 18:35:58 UTC
The regression was introduced in c51c15144e3fbdd3ebed301a077c687e23882e09 in Samba 4.14 and fixed with 942c0d2128cb8e64a9354dde6bdae82a1c1c3d88 for Samba 4.15 so only a 4.14 backport is needed.
Comment 3 Andrew Bartlett 2021-04-18 18:47:47 UTC
Created attachment 16590 [details]
patch from master backported to 4.14 (only)
Comment 4 Andrew Bartlett 2021-04-19 01:53:04 UTC
Assigning to Karolin for the next 4.14
Comment 5 Karolin Seeger 2021-04-19 07:12:50 UTC
(In reply to Andrew Bartlett from comment #4)
Pushed to autobuild-v4-14-test.
Comment 6 Samba QA Contact 2021-04-20 07:40:20 UTC
This bug was referenced in samba v4-14-test:

Comment 7 Samba QA Contact 2021-04-20 10:10:56 UTC
This bug was referenced in samba v4-14-stable (Release samba-4.14.3):

Comment 8 Karolin Seeger 2021-04-20 11:11:53 UTC
Closing out bug report.