Bug 14536 - Avoid nss function conflicts with glibc nss.h
Summary: Avoid nss function conflicts with glibc nss.h
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.13.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-19 14:24 UTC by Andreas Schneider
Modified: 2020-10-30 12:18 UTC (History)
2 users (show)

See Also:


Attachments
patch for 4.13 (2.73 KB, patch)
2020-10-19 14:25 UTC, Andreas Schneider
ab: review+
Details
patch for 4.12 (2.73 KB, patch)
2020-10-19 14:26 UTC, Andreas Schneider
ab: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2020-10-19 14:24:37 UTC
Avoid nss function conflicts with glibc nss.h

```
[2386/3815] Compiling nsswitch/nsstest.c
../../nsswitch/nsstest.c:140:13: error: ‘nss_setpwent’ redeclared as different kind of symbol
  140 | static void nss_setpwent(void)
      |             ^~~~~~~~~~~~
In file included from ../../nsswitch/nsstest.h:53,
                 from ../../nsswitch/nsstest.c:22:
/usr/include/nss.h:186:25: note: previous declaration of ‘nss_setpwent’ was here
  186 | typedef enum nss_status nss_setpwent (int);
      |                         ^~~~~~~~~~~~
../../nsswitch/nsstest.c:155:13: error: ‘nss_endpwent’ redeclared as different kind of symbol
  155 | static void nss_endpwent(void)
      |             ^~~~~~~~~~~~
In file included from ../../nsswitch/nsstest.h:53,
                 from ../../nsswitch/nsstest.c:22:
/usr/include/nss.h:87:25: note: previous declaration of ‘nss_endpwent’ was here
   87 | typedef enum nss_status nss_endpwent (void);
      |                         ^~~~~~~~~~~~
../../nsswitch/nsstest.c:293:13: error: ‘nss_setgrent’ redeclared as different kind of symbol
  293 | static void nss_setgrent(void)
      |             ^~~~~~~~~~~~
In file included from ../../nsswitch/nsstest.h:53,
                 from ../../nsswitch/nsstest.c:22:
/usr/include/nss.h:181:25: note: previous declaration of ‘nss_setgrent’ was here
  181 | typedef enum nss_status nss_setgrent (int);
      |                         ^~~~~~~~~~~~
../../nsswitch/nsstest.c:308:13: error: ‘nss_endgrent’ redeclared as different kind of symbol
  308 | static void nss_endgrent(void)
      |             ^~~~~~~~~~~~
In file included from ../../nsswitch/nsstest.h:53,
                 from ../../nsswitch/nsstest.c:22:
/usr/include/nss.h:82:25: note: previous declaration of ‘nss_endgrent’ was here
   82 | typedef enum nss_status nss_endgrent (void);
      |                         ^~~~~~~~~~~~
```
Comment 1 Andreas Schneider 2020-10-19 14:25:48 UTC
Created attachment 16286 [details]
patch for 4.13
Comment 2 Andreas Schneider 2020-10-19 14:26:30 UTC
Created attachment 16287 [details]
patch for 4.12
Comment 3 Alexander Bokovoy 2020-10-19 15:58:08 UTC
LGTM.
Comment 4 Andreas Schneider 2020-10-19 17:43:32 UTC
Karolin, please appyl the patches to the relevant branches. Thanks!
Comment 5 Karolin Seeger 2020-10-26 09:57:24 UTC
(In reply to Andreas Schneider from comment #4)
Pushed to autobuild-v4-{12,13}-test.
Comment 6 Karolin Seeger 2020-10-30 12:18:03 UTC
Pushed to both branches.
Closing out bug report.

Thanks!