Bug 14532 - Two SMB2_LOGOFF messages kill the whole client smbd when multi-channel is used
Summary: Two SMB2_LOGOFF messages kill the whole client smbd when multi-channel is used
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.13.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 14534
  Show dependency tree / graph
 
Reported: 2020-10-14 12:43 UTC by Stefan Metzmacher
Modified: 2021-03-17 01:57 UTC (History)
3 users (show)

See Also:

Attachments
Work in progress patches for master (5.47 KB, patch)
2020-10-14 12:43 UTC, Stefan Metzmacher 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2020-10-14 12:43:51 UTC 
Created attachment 16283 [details]
Work in progress patches for master

With multichannel turned on an SMB2 session logoff with more than one channel/connection seems leave stale pointers and lead to a panic.
Comment 1 Jeremy Allison 2021-02-22 20:25:45 UTC 
Hi Metze, where are we with this ? Looks like a customer has hit this in production and we should fix it up in a release I think.

Are your patches good to go ?
Comment 2 Stefan Metzmacher 2021-02-23 08:57:52 UTC 
(In reply to Jeremy Allison from comment #1)

I hope to have them ready soon, but I got distracted by other things.
Comment 3 Samba QA Contact 2021-03-06 03:31:28 UTC 
This bug was referenced in samba master:

2cf1628419f5035107d1be6d7ab1bf6533bad7a2
253a4de82bd4e44586572b71e06762c3f6dbd795
638c4435a0eeb110719dd2e799f2a12758667326
Comment 4 Stefan Metzmacher 2021-03-10 12:35:33 UTC 
This is fixed in master now and will be included in 4.15.

(We may backport this to 4.14 at a later time...)
Comment 5 Samba QA Contact 2021-03-17 01:57:12 UTC 
This bug was referenced in samba master:

3242a0b091899068943072b9c509452931042542