Bug 14330 - LMDB databases can grow without bounds
Summary: LMDB databases can grow without bounds
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.12.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL: https://gitlab.com/samba-team/samba/-...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-30 23:37 UTC by Andrew Bartlett
Modified: 2020-05-19 10:22 UTC (History)
2 users (show)

See Also:


Attachments
Patch for V4.12 (v1) (21.45 KB, patch)
2020-04-20 04:23 UTC, Gary Lockyer
metze: review-
gary: ci-passed+
Details
Patch for V4.11 (v1) (21.45 KB, patch)
2020-04-20 04:24 UTC, Gary Lockyer
metze: review-
gary: ci-passed+
Details
Patch for V4.12 (v2) (44.83 KB, patch)
2020-05-03 20:37 UTC, Gary Lockyer
gary: review? (metze)
abartlet: review+
gary: ci-passed+
Details
Patch for V4.11 (v2) (44.79 KB, patch)
2020-05-03 20:43 UTC, Gary Lockyer
gary: review? (metze)
abartlet: review+
gary: ci-passed+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2020-03-30 23:37:37 UTC
The LMDB driver for LDB did not automatically clean up after a read process that did not release its own lock.

This could cause DB updates to fail as no space could be found for the newly modified record as the DB incorrectly assumed that a reader was still active.
Comment 1 Gary Lockyer 2020-04-20 04:23:04 UTC
Created attachment 15932 [details]
Patch for V4.12 (v1)

CI: https://gitlab.com/samba-team/devel/samba/pipelines/137709227
Comment 2 Gary Lockyer 2020-04-20 04:24:28 UTC
Created attachment 15933 [details]
Patch for V4.11 (v1)

CI: https://gitlab.com/samba-team/devel/samba/pipelines/137681635
Comment 3 Gary Lockyer 2020-04-20 04:25:07 UTC
No need to backport to 4.10 as lmdb support was added in V4.11
Comment 4 Stefan Metzmacher 2020-04-20 08:19:48 UTC
Comment on attachment 15932 [details]
Patch for V4.12 (v1)

This needs ldb release coordination...
Comment 5 Stefan Metzmacher 2020-04-20 08:20:18 UTC
Comment on attachment 15933 [details]
Patch for V4.11 (v1)


This needs ldb release coordination...
Comment 6 Gary Lockyer 2020-04-20 21:43:30 UTC
(In reply to Stefan Metzmacher from comment #5)
Thanks metze I'll do this and resubmit the patches.
Comment 7 Gary Lockyer 2020-05-03 20:37:30 UTC
Created attachment 15949 [details]
Patch for V4.12 (v2)

CI: https://gitlab.com/samba-team/devel/samba/pipelines/141611824
Comment 8 Gary Lockyer 2020-05-03 20:43:28 UTC
Created attachment 15950 [details]
Patch for V4.11 (v2)

CI: https://gitlab.com/samba-team/devel/samba/pipelines/141615684
Comment 9 Andrew Bartlett 2020-05-12 21:22:42 UTC
Assigning to Karolin for the next 4.11 and 4.12 releases.
Comment 10 Karolin Seeger 2020-05-13 10:30:58 UTC
(In reply to Andrew Bartlett from comment #9)
Pushed to autobuild-v4-{12,11}-test.
Comment 11 Karolin Seeger 2020-05-19 10:22:17 UTC
Closing out bug report.

Thanks!