Bug 14203 - Selftest tests missing for many test binaries
Summary: Selftest tests missing for many test binaries
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Test infrastructure (show other bugs)
Version: 4.11.2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-22 18:45 UTC by Andrew Bartlett
Modified: 2019-11-22 18:45 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2019-11-22 18:45:33 UTC 
While developing 6107c79c90fdff3fe60e0d0ef3efe57b52b21262 I noticed that a large number of apparently selftest binaries do not appear to be run in our selftest (as determined by git grep):

     - test_lp_load
     - notifyd-tests
     - test* from examples/libsmbclient
     - dbwrap_torture
     - split_tokens
     - locktest2
     - msgtest
     - msg_sink
     - msg_source
     - versiontest
     - rpc_open_tcp
     - test_headers

Note that I may have missed some (one way or the other). 

Note that because the binaries are not executed, they wont show up in the coverage report at https://samba-team.gitlab.io/devel/samba either.

These test binaries would have been written for a reason, so we should work to include these in the selftest to ensure they keep our code tested under CI.