Bug 14111 - Correcting the error message of 'samba-tool domain schemaupgrade'
Summary: Correcting the error message of 'samba-tool domain schemaupgrade'
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.10.4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-02 11:47 UTC by Amit Kumar
Modified: 2019-09-02 11:47 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Kumar 2019-09-02 11:47:17 UTC 
- Present error message 
"Failed to upgrade schema. Check if 'patch' is installed."

- Should log this message:
"Failed to upgrade schema. Check if package 'patch' is installed.
Try running 'yum install patch'"

# samba-tool domain schemaupgrade -d 4
lpcfg_load: refreshing parameters from /etc/samba/smb.conf
Processing section "[global]"
Processing section "[sysvol]"
Processing section "[netlogon]"
pm_process() returned Yes
Temporarily overriding 'dsdb:schema update allowed' setting
ERROR: Failed to upgrade schema. Check if 'patch' is installed.
  File "/usr/lib64/python3.7/site-packages/samba/netcmd/domain.py", line 4231, in run
    stderr=subprocess.PIPE, cwd=temp_folder)
  File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib64/python3.7/subprocess.py", line 1522, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)

MR: https://gitlab.com/samba-team/samba/merge_requests/758