Testing has revealed that Samba and Gluster can achieve a significant performance boost when using pthreadpool from within vfs_glusterfs, see attached patch.
Created attachment 15421 [details] proposed patch for master
Created attachment 15432 [details] patch for v4-11
Created attachment 15433 [details] patch for v4-10
Created attachment 15434 [details] patch for v4-9 Patch for v4-9 is not a cherry-pick from master due to profiling macro changes in fsync operations.
Comment on attachment 15432 [details] patch for v4-11 LGTM
Comment on attachment 15433 [details] patch for v4-10 LGTM
Comment on attachment 15434 [details] patch for v4-9 LGTM
Re-assigning to Karolin for inclusion in 4.9.next, 4.10.next, 4.11.next. Anoop - you need to produce a patch for inclusion in 4.12.rcNext also to ensure it gets into the next stable release. Thanks ! Jeremy.
Hm, Jeremy, I think Anoop already provided the necessary patches for all branches (4.9, 4.10 and 4.11) + the patch is in master. AFAICT no other patches required.
(In reply to Guenther Deschner from comment #9) Yes you're right, I got confused as to whether 4.11 was out yet, sorry :-).
Pushed to autobuild-v4-{11,10,9}-test.
(In reply to Karolin Seeger from comment #11) Pushed to all branches. Closing out bug report. Thanks!
isn't a major change like this unsuited for getting into a stable release? I have a case where this change caused a 75% performance drop also with Samba 4.10.
Günther, Anoop: the performance regression can be seen with centos7 with Samba 4.10 running on a Linux or mac SMB client: fio --readwrite=read --bs=1M --size=10G --name=test --ioengine=libaio --iodepth=8 Which OS / Samba release combinations did you test your patch with and how did the performance tests from your site look like ?
(In reply to Björn Jacke from comment #13) 75% drop? What was the workload? (In reply to Björn Jacke from comment #14) Ok. We will try to analyze based on mentioned job profile. IIRC, tests were carried out with v4.9.x on RHEL 7. It was some kind of Disk Performance tool ran from Windows showing significant performance boost as depicted in this slide[1]. Also, is there any special configuration used? I don't think we had anything specific other than required settings for vfs_glusterfs use case. [1] https://www.samba.org/~anoopcs/presentations/slides/SambaXP%202020%20-%20Field%20report.pdf#page=15