Bug 13960 - Samba/libtalloc/libtdb/libtevent/libldb fails to build with Python 3.8
Samba/libtalloc/libtdb/libtevent/libldb fails to build with Python 3.8
Status: RESOLVED FIXED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build
4.10.0
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-22 08:12 UTC by Andreas Schneider
Modified: 2019-08-09 07:58 UTC (History)
3 users (show)

See Also:


Attachments
patch for 4.10 (119.41 KB, patch)
2019-06-17 11:09 UTC, Andreas Schneider
ab: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2019-05-22 08:12:50 UTC
Samba/libtalloc/libtdb/libtevent/libldb fails to build with Python 3.8.

Checking for pyembed fails because it is not really supported by the python3-config anymore, see https://bugs.python.org/issue36721
Comment 1 Andreas Schneider 2019-05-22 08:26:27 UTC
Ok, this is a python3 change. We need to fix waf to look up pyembed correctly as libpytalloc-util requires it!
Comment 2 Andreas Schneider 2019-05-22 15:26:41 UTC
waf bug: https://gitlab.com/ita1024/waf/issues/2239
Comment 3 Andreas Schneider 2019-06-17 11:09:14 UTC
Created attachment 15252 [details]
patch for 4.10
Comment 4 Alexander Bokovoy 2019-06-17 11:47:32 UTC
Comment on attachment 15252 [details]
patch for 4.10

LGTM. Please create a CI run on gitlab too.
Comment 5 Karolin Seeger 2019-08-06 08:04:50 UTC
(In reply to Alexander Bokovoy from comment #4)
Pushed to autobuild-v4-10-test.
Patch adds trailing whitespaces.
Comment 6 Andreas Schneider 2019-08-06 08:57:58 UTC
Yes, that's from waf upstream repo. Andrew didn't want to remove them :-)
Comment 7 Karolin Seeger 2019-08-09 07:58:17 UTC
Pushed to v4-10-test.
Closing out bug report.

Thanks!