Bug 13786 - messaging gets stuck when pids are recycled
Summary: messaging gets stuck when pids are recycled
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.10.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-13 10:00 UTC by Stefan Metzmacher
Modified: 2019-03-06 08:49 UTC (History)
3 users (show)

See Also:

Attachments
Patches for v4-10-test (7.55 KB, patch)
2019-03-01 19:41 UTC, Stefan Metzmacher 		vl: review+
Details
Patches for v4-9-test (7.55 KB, patch)
2019-03-01 19:41 UTC, Stefan Metzmacher 		vl: review+
Details
Patches for v4-8-test (7.55 KB, patch)
2019-03-01 19:41 UTC, Stefan Metzmacher 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2019-02-13 10:00:03 UTC 
The messaging_dgm code caches connected datagram sockets based on the
destination pid for 1 second.
    
The fact that samba_dnsupdate constantly recreates its messaging
context (and the underlying datagram socket) means that we the winbindd
messaging context may get a stale connection. As a result sending any
message from winbindd back to samba_dnsupdate will result in
ECONNREFUSED.
    
That means the IRPC response from winbindd never reaches
samba_dnsupdate, which will then hit a timeout.
    
In turn samba_dnsupdate on the RODC times out.
Comment 1 Stefan Metzmacher 2019-03-01 19:41:03 UTC 
Created attachment 14888 [details]
Patches for v4-10-test
Comment 2 Stefan Metzmacher 2019-03-01 19:41:30 UTC 
Created attachment 14889 [details]
Patches for v4-9-test
Comment 3 Stefan Metzmacher 2019-03-01 19:41:55 UTC 
Created attachment 14890 [details]
Patches for v4-8-test
Comment 4 Karolin Seeger 2019-03-04 10:27:13 UTC 
Pushed to autobuild-v4-{10,9,8}-test.
Comment 5 Karolin Seeger 2019-03-06 08:49:03 UTC 
(In reply to Karolin Seeger from comment #4)
Pushed to all branches.
Closing out bug report.

Thanks!