Bug 13775 - winbind code still talks about Windows 2003 AD
Summary: winbind code still talks about Windows 2003 AD
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
Depends on:
Reported: 2019-02-05 12:08 UTC by Amit Kumar
Modified: 2021-03-22 02:16 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Amit Kumar 2019-02-05 12:08:52 UTC
I found this code.

static void rescan_forest_trusts( void )
        /* The only transitive trusts supported by Windows 2003 AD are
           (a) Parent-Child, (b) Tree-Root, and (c) Forest.   The
           first two are handled in forest and listed by
           DsEnumerateDomainTrusts().  Forest trusts are not so we
           have to do that ourselves.

What I feel:
1. We should update the code comments for with "Windows 2016" trust support, If supported.
2. Or we should make this as generic statement.
Comment 1 Andrew Bartlett 2021-03-22 02:16:31 UTC
Comments are made at the time and in the context of what the developer can assert at that point, they don't need to be updated like this.