Bug 13636 - vfs_fruit cannot create multiple tags on a file
Summary: vfs_fruit cannot create multiple tags on a file
Status: RESOLVED DUPLICATE of bug 13646
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.8.5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Ralph Böhme
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-01 08:23 UTC by SATOH Fumiyasu
Modified: 2018-10-23 15:00 UTC (History)
0 users

See Also:


Attachments
smbd's log (1.58 MB, text/x-log)
2018-10-01 08:23 UTC, SATOH Fumiyasu
no flags Details
smbd's log of the similar issue (comment #2) (1.84 MB, text/x-log)
2018-10-01 08:46 UTC, SATOH Fumiyasu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description SATOH Fumiyasu 2018-10-01 08:23:47 UTC
Created attachment 14503 [details]
smbd's log

Environment
----------------------------------------------------------------------

OS: CentOS 7.4
Affect Samba version: 4.8.5
No affect Samba version: 4.8.4 and older

smb.conf
----------------------------------------------------------------------

```
[stock1]
path = /data/stock1
writeable = yes
vfs objects = catia fruit streams_xattr
fruit:encoding = native
fruit:veto_appledouble = no
streams_xattr:prefix = user.
streams_xattr:store_stream_type = no
```

Steps to reproduce
----------------------------------------------------------------------

  1. On macOS local filesystem, create a file and add multiple tags
     to the file.
  2. Copy the file to a Samba SMB share.
  3. On the Samba SMB share, add a tag to the file.

Expected result
----------------------------------------------------------------------

A tag is added to the file without error.

Actual result
----------------------------------------------------------------------

A tag is added to the file with the error dialog window:
"The operation can't be completed. An unexpected error occurred (error code-8058)."
Comment 1 SATOH Fumiyasu 2018-10-01 08:35:48 UTC
There is a similar issue.

Steps to reproduce
----------------------------------------------------------------------

  1. On the Samba SMB share, create a file (or folder).
  2. Add a color tag to the file.
  3. Add another color tag to the file.

Expected result
----------------------------------------------------------------------

Multiple color tag are added to the file without error.

Actual result
----------------------------------------------------------------------

Only the last color tag is added to the file without error.
Comment 2 SATOH Fumiyasu 2018-10-01 08:46:47 UTC
Created attachment 14504 [details]
smbd's log of the similar issue (comment #2)

Quote from lines from the attached file:

[2018/10/01 17:41:13, 10, pid=13397, effective(1002, 100), real(1002, 0)] ../source3/smbd/trans2.c:241(get_ea_value)
  get_ea_value: EA user.com.apple.metadata_kMDItemUserTags is of length 71
[2018/10/01 17:41:13, 10, pid=13397, effective(1002, 100), real(1002, 0)] ../lib/util/util.c:514(dump_data)
  [0000] 62 70 6C 69 73 74 30 30   A2 01 02 65 30 EC 30 C3   bplist00 ...e0.0.
  [0010] 30 C9 00 0A 00 36 66 30   AA 30 EC 30 F3 30 B8 00   0....6f0 .0.0.0..
  [0020] 0A 00 37 08 0B 16 00 00   00 00 00 00 01 01 00 00   ..7..... ........
  [0030] 00 00 00 00 00 03 00 00   00 00 00 00 00 00 00 00   ........ ........
  [0040] 00 00 00 00 00 23 00                    

"30 EC 30 C3 30 C9" is a Japanese word "レッド" in UTF-16BE, it means "Red".
"30 AA 30 EC 30 F3 30 B8" is a Japanese word "オレンジ" in UTF-16BE, it means "Orange".
Comment 3 SATOH Fumiyasu 2018-10-01 09:15:42 UTC
macOS versions: macOS 10.13.4 (High Sierra), Mac OS X 10.11
Comment 4 SATOH Fumiyasu 2018-10-01 10:48:41 UTC
Samba 4.8.5 without af4cb57d4f713990973f44678dc5e6d2f9cfa984 (patch for bug #13441) is no problem.
Comment 5 Ralph Böhme 2018-10-05 10:16:38 UTC
You need the follow-up fix 8c14234871820eacde46670d722a676fb5f3a46c for bug 13441. The fix will ship with 4.8.6.

*** This bug has been marked as a duplicate of bug 13441 ***
Comment 6 SATOH Fumiyasu 2018-10-05 10:43:23 UTC
I can reproduce this bug with 8c14234871820eacde46670d722a676fb5f3a46c.
Comment 7 Ralph Böhme 2018-10-05 13:08:57 UTC
(In reply to SATOH Fumiyasu from comment #6)
Ah, ok. Yes, this is another known issue, I'm working on it.
Comment 8 Ralph Böhme 2018-10-23 15:00:35 UTC

*** This bug has been marked as a duplicate of bug 13646 ***