Bug 13460 - Missing extern "C" specifications in libsmbclient.h (c++ issue)
Summary: Missing extern "C" specifications in libsmbclient.h (c++ issue)
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: 4.8
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-01 07:07 UTC by Svyatoslav Phirsov
Modified: 2018-06-14 09:37 UTC (History)
0 users

See Also:

Attachments
Proposed patch (1.67 KB, patch)
2018-06-06 08:46 UTC, Svyatoslav Phirsov 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Svyatoslav Phirsov 2018-06-01 07:07:24 UTC 
Several functions (e.g. smbc_set_credentials) in libsmbclient.h declared without extern "C" specification. This leads to linker error when building C++ application using libsmbclient
Comment 1 Björn Jacke 2018-06-05 08:28:51 UTC 
can you provide a patch fixing those missing for you?
Comment 2 Svyatoslav Phirsov 2018-06-06 08:46:30 UTC 
Created attachment 14223 [details]
Proposed patch

Proposed patch to ensure all functions in libsmbclient.h have extern "C" linkage specification
Comment 3 Björn Jacke 2018-06-14 09:37:05 UTC 
Metze says libsmbclient.h is currently Jeremy's business. So Jeremy, can you have a look at the attached patch from Svyatoslav?