Bug 13277 - new ceph-common detection fails with system path and with older ceph releases
new ceph-common detection fails with system path and with older ceph releases
Status: ASSIGNED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build
4.8.0rc2
All All
: P5 normal
: ---
Assigned To: Guenther Deschner
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-16 14:43 UTC by Guenther Deschner
Modified: 2018-03-22 20:46 UTC (History)
2 users (show)

See Also:


Attachments
possible patch (1.37 KB, patch)
2018-02-16 14:44 UTC, Guenther Deschner
ddiss: review+
Details
patch from master for 4.8, 4.7 and 4.6 (1.70 KB, patch)
2018-02-22 21:00 UTC, Guenther Deschner
ddiss: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guenther Deschner 2018-02-16 14:43:57 UTC
The changes that came in via #13250 (ff7df3d3f5259362a6bb6780d6b532e57e89681d) cause problems with:

a) older ceph releases that do not have a libceph-common.so at all (like libcephfs1-10.2.7-2.fc26.x86_64 on Fedora26)

b) libceph-common.so installed under /usr/lib{64}/ceph (just like in librados2-12.2.2-1.fc28.x86_64 on Fedora rawhide/28)

I guess we need to look for libceph-common.so at least also under /usr/lib{64}/ceph *and* we should not insist on libceph-common.so being present at all (for older ceph setups).

Attached patch tries to fix that.
Comment 1 Guenther Deschner 2018-02-16 14:44:57 UTC
Created attachment 13966 [details]
possible patch
Comment 2 David Disseldorp 2018-02-16 15:02:31 UTC
The patch looks good to me. I'd like to give it a quick test on my side before pushing. Thanks for catching this Günther.
Comment 3 David Disseldorp 2018-02-21 22:44:32 UTC
Comment on attachment 13966 [details]
possible patch

rb: me . Apologies for the headache.
Comment 4 Guenther Deschner 2018-02-22 21:00:23 UTC
Created attachment 13974 [details]
patch from master for 4.8, 4.7 and 4.6
Comment 5 Karolin Seeger 2018-02-28 11:11:48 UTC
Pushed autobuild-v4-{8,7,6}-test.
Comment 6 Stefan Metzmacher 2018-03-07 12:00:37 UTC
(In reply to Karolin Seeger from comment #5)

Pushed to v4-{7,8}-test, v4-6-test still needed.
Comment 7 Karolin Seeger 2018-03-22 20:46:50 UTC
Patch does not apply on current v4-6-test branch.
Re-assigning to Günther to decide whether it's needed for 4.6 or not.