Bug 12881 - smbclient: enhancement request: add negotiated protocol (SMB1, SMB2, SMb3) in output
Summary: smbclient: enhancement request: add negotiated protocol (SMB1, SMB2, SMb3) in...
Status: RESOLVED WONTFIX
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.7.0rc1
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on: 12863
Blocks:
  Show dependency tree / graph
 
Reported: 2017-07-05 22:25 UTC by Giulio
Modified: 2021-11-21 19:55 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Giulio 2017-07-05 22:25:13 UTC 
Since smbclient is now defaulting to "max protocol = smb3", it would be useful for smbclient to output the negotiated protocol.


Ie:
smbclient -d <you.decide>  ...
Remote server max protocol SMBx, local client max protocol SMBy, negotiated SMBz
Try "help" do get a list of possible commands.
smb: \>


Right now, even with -d 10, it's not very clear which protocol is negotiated and why.

Thanks
Comment 1 Stefan Metzmacher 2017-08-16 10:46:27 UTC 
We can add "negotiated dialect[SMB2_10] against server[172.31.9.133]" with log level 4 similar to the "session request ok" message.

The real list would be to add/extend commands like "listconnect" or "showconnect", but that needs more work as we would want a lot more details
in addition to the selected dialect.
Comment 2 Stefan Metzmacher 2017-08-30 07:14:38 UTC 
This the fixes from bug #12863 this is no longer blocking 4.7.0.

We keep this open for the potential "listconnect" or "showconnect" enhancements.