Bug 12425 - Remote machine architecture detection cannot recognize Win7/Win8/Win10
Remote machine architecture detection cannot recognize Win7/Win8/Win10
Status: ASSIGNED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other
4.3.12
All All
: P5 normal
: ---
Assigned To: Jeremy Allison
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-11-14 09:30 UTC by Zhang Zujian
Modified: 2016-11-17 01:08 UTC (History)
0 users

See Also:


Attachments
patch for v4.3 (10.27 KB, patch)
2016-11-14 09:30 UTC, Zhang Zujian
no flags Details
patch for v4.4 (1.82 KB, patch)
2016-11-14 09:31 UTC, Zhang Zujian
no flags Details
patch for v4.5 (1.77 KB, patch)
2016-11-14 09:31 UTC, Zhang Zujian
no flags Details
patch for master (3.57 KB, patch)
2016-11-16 02:40 UTC, Zhang Zujian
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zhang Zujian 2016-11-14 09:30:06 UTC
Win7/Win8/Win8.1/Win10 are all recognized as Vista.
Comment 1 Zhang Zujian 2016-11-14 09:30:37 UTC
Created attachment 12658 [details]
patch for v4.3
Comment 2 Zhang Zujian 2016-11-14 09:31:29 UTC
Created attachment 12659 [details]
patch for v4.4
Comment 3 Zhang Zujian 2016-11-14 09:31:52 UTC
Created attachment 12660 [details]
patch for v4.5
Comment 4 Jeremy Allison 2016-11-15 00:55:52 UTC
These look good - can you post a patch for master on samba-technical@lists.samba.org and once that's in we can add these as back-ports !

Cheers,

Jeremy.
Comment 5 Zhang Zujian 2016-11-15 07:05:36 UTC
The patch I posted for v4.3 includes fix for https://bugzilla.samba.org/show_bug.cgi?id=11773. I forgot about that.

So please don't use the patch for v4.3.

I have posted patches for v4.4, v4.5 and master on samba-technical@lists.samba.org.
Comment 6 Björn Jacke 2016-11-15 13:29:08 UTC
These patches should *not* go into stable release branches as they change bahaviour where users might rely on (imaging people using path names with %a in it).

Can you please also enhance the man page accordingly?
Comment 7 Zhang Zujian 2016-11-16 02:40:50 UTC
Created attachment 12668 [details]
patch for master
Comment 8 Zhang Zujian 2016-11-16 02:41:57 UTC
(In reply to Björn Jacke from comment #6)

You are right. I use %a only in the full_audit vfs module so I ignored other situations.

The new attachment is patch for master with man page update.
Comment 9 Zhang Zujian 2016-11-17 01:08:17 UTC
(In reply to Björn Jacke from comment #6)

From discussion on samba-technical@lists.samba.org, I think the patch is not mature enough.