Bug 122 - smbclient ignores Unix locale settings when choosing a charset
Summary: smbclient ignores Unix locale settings when choosing a charset
Status: CLOSED FIXED
Alias: None
Product: Samba 3.0
Classification: Unclassified
Component: smbclient (show other bugs)
Version: 3.0.0preX
Hardware: All Linux
: P1 normal
Target Milestone: none
Assignee: Andrew Tridgell
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-25 19:10 UTC by Steve Langasek
Modified: 2005-08-24 10:18 UTC (History)
0 users

See Also:

Attachments
Patch to add support for setlocale/nl_langinfo querying (3.80 KB, patch)
2003-05-25 19:12 UTC, Steve Langasek 		no flags Details
Updated patch (3.62 KB, patch)
2003-06-21 10:31 UTC, Steve Langasek 		no flags Details
Patch for associated documentation (1.05 KB, patch)
2003-06-29 19:16 UTC, Steve Langasek 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Langasek 2003-05-25 19:10:04 UTC 
Currently, smbclient uses the value of 'display charset' from smb.conf to decide
what character set to use when displaying filenames.  This is sub-optimal,
because most users of modern Unices that need non-ASCII characters will have
configured their locale settings by standard means, and will not want to edit
additional per-application config files.  Samba should preferentially use the
locale information from the native system, and only fall back on 'display
charset' if this is unavailable or unsupported.

Patch to follow.
Comment 1 Steve Langasek 2003-05-25 19:12:11 UTC 
Created attachment 16 [details]
Patch to add support for setlocale/nl_langinfo querying
Comment 2 John H Terpstra (mail address dead( 2003-06-14 23:09:29 UTC 
Patch applied following discussions with abartlet and vorlon.
Comment 3 Steve Langasek 2003-06-21 10:30:22 UTC 
Patch was reverted
Comment 4 Steve Langasek 2003-06-21 10:31:59 UTC 
Created attachment 32 [details]
Updated patch

Previous patch has been backed out by tridge due to a number of problems.  This
patch should address his objections, while preserving the previous patch's
ability to cope gracefully nl_langinfo() implementations that don't provide
suitable input for iconv_open().
Comment 5 Andrew Tridgell 2003-06-29 19:13:15 UTC 
accepted patch
Comment 6 Steve Langasek 2003-06-29 19:16:13 UTC 
Created attachment 38 [details]
Patch for associated documentation

And a patch for the xml description of this parameter, as well.
Comment 7 Andrew Bartlett 2003-06-29 19:16:43 UTC 
Closing this for tridge
Comment 8 Gerald (Jerry) Carter (dead mail address) 2005-02-07 07:57:25 UTC 
originally reported against 3.0aph24.  Bugzilla spring cleaning.  
Removing old alpha versions.
Comment 9 Gerald (Jerry) Carter (dead mail address) 2005-08-24 10:18:20 UTC 
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.