Bug 12167 - Add error message for enablerecyclebin script, if functional level is to low
Summary: Add error message for enablerecyclebin script, if functional level is to low
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.5.0rc2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-18 22:55 UTC by Marc Muehlfeld
Modified: 2016-08-23 04:03 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Muehlfeld 2016-08-18 22:55:19 UTC 
In the case that the forest level is 2003, the try to enable the Samba AD recycle bin fails with a weird error:

# source4/scripting/bin/enablerecyclebin /usr/local/samba/private/sam.ldb
Traceback (most recent call last):
  File "source4/scripting/bin/enablerecyclebin", line 51, in <module>
    res = sam_ldb.modify(msg)
_ldb.LdbError: (53, 'rootdse: failed to set optional feature for 766ddcd8-acd0-445e-f3b9-a7f9b6744f2a - rootdse_enable_recycle_bin: Domain functional level must be at least 4\n')


This feature is supported in forest functional level 2008r2 and later.


Since 4.5 will provide better support for tombstones, etc., the script should display a nice error message. :-)
Comment 1 Andrew Bartlett 2016-08-23 04:03:44 UTC 
It should be noted that the recycle bin in Samba is untested and even less well understood.  

We should probably move the script to scripting/devel until that improves.