Bug 11981 - @ specified in force group not picked up by testparm causes mount error
Summary: @ specified in force group not picked up by testparm causes mount error
Status: RESOLVED WONTFIX
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.3.9
Hardware: All Linux
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-20 10:29 UTC by Paul
Modified: 2016-11-09 09:25 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul 2016-06-20 10:29:18 UTC 
Made a configuration error in specifying the force group in smb.conf - put a @ in front of the group command.

i.e.

force group = @groupname

should have been

force group = groupname

Not picked up by testparm and causes Linux client to have issues mounting it:

Error: Failed to mount Windows share: Invalid argument
Please select another viewer and try again.

Removed the extra @ in the force group command and the problem goes away.  Would have expected the testparm util to pick up this issue.  Took a long time to diagnose the issue and it would have been nice for testparm to pick this up.

Paul
Comment 1 Karolin Seeger 2016-11-09 09:25:43 UTC 
I think it's possible to have groups containing (and starting with"@"), so it wouldn't make sense to make testparm complain about the "@".

Unfortunately it's confusing that some parameters like "valid users" which accept both, users and groups, use the "@" to specify groups and others that accept groups only don't...

Closing out bug report as won't fix for now. Please feel free to re-open if more discussion is needed.

Thanks!

Karolin