Build failure on AIX 7.1.3, lib/tdb/tools/tdbtool.c, disable_lock name conflict AIX Version: 7100-03-05-1524 XLC Version: 13.01.0003.0000 Samba Version: 4.3.4 Make fails with the following error: [1119/3427] Compiling lib/tdb/tools/tdbtool.c "../lib/tdb/tools/tdbtool.c", line 39.12: 1506-343 (S) Redeclaration of disable_lock differs from previous declaration on line 314 of "/usr/include/sys/lock_def.h". "../lib/tdb/tools/tdbtool.c", line 39.12: 1506-382 (I) The type "int" of identifier disable_lock differs from previous type "int(int,union _simple_lock*)". Waf: Leaving directory `/usr/src/samba-4.3.4/bin' Build failed: -> task failed (err #1): {task: cc tdbtool.c -> tdbtool_12.o} This is an unfortunate name clash with the unrelated disable_lock kernel service included by lib/replace/system/filesys.h -> /usr/include/sys/vfs.h ---> /usr/include/sys/gfs.h -----> /usr/include/sys/lock_def.h Renaming tdbtool.c's disable_lock to something else fixes the problem.
Created attachment 11864 [details] Proposed patch
This also applies to Samba 4.4.3 with xlc compiler 13.1.3 This patch works correctly
Works also for 4.5.1
this was fixed in master with edffe4d16514fa0c87655e040842f6c20d89791c
*** This bug has been marked as a duplicate of bug 13493 ***