Attachment 9946 Details for Bug 10466 – Patch to correctly provision the minTTL field in SOA records

[patch] Patch to correctly provision the minTTL field in SOA records

0001-provision-Correctly-provision-the-SOA-record-minimum.patch (text/plain), 1.29 KB, created by Kai Blin on 2014-05-16 16:36:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kai Blin

Created: 2014-05-16 16:36:14 UTC

Size: 1.29 KB

patch

obsolete

>From 5b93510fb0a622fdc1060371d8aaaf0b6a7aedbb Mon Sep 17 00:00:00 2001
>From: Kai Blin <kai@samba.org>
>Date: Fri, 16 May 2014 18:33:42 +0200
>Subject: [PATCH] provision: Correctly provision the SOA record minimum TTL
>
>This fixes bug #10466
>
>Signed-off-by: Kai Blin <kai@samba.org>
>---
> python/samba/provision/sambadns.py | 1 +
> python/samba/tests/dns.py          | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/python/samba/provision/sambadns.py b/python/samba/provision/sambadns.py
>index 13e03ab..f1cb1e2 100644
>--- a/python/samba/provision/sambadns.py
>+++ b/python/samba/provision/sambadns.py
>@@ -130,6 +130,7 @@ class SOARecord(dnsp.DnssrvRpcRecord):
>         soa.expire = expire
>         soa.mname = mname
>         soa.rname = rname
>+        soa.minimum = minimum
>         self.data = soa
> 
> 
>diff --git a/python/samba/tests/dns.py b/python/samba/tests/dns.py
>index 9c0b274..5dc3d1f 100644
>--- a/python/samba/tests/dns.py
>+++ b/python/samba/tests/dns.py
>@@ -289,6 +289,7 @@ class TestSimpleQueries(DNSTest):
>         self.assert_dns_rcode_equals(response, dns.DNS_RCODE_OK)
>         self.assert_dns_opcode_equals(response, dns.DNS_OPCODE_QUERY)
>         self.assertEquals(response.ancount, 1)
>+        self.assertEquals(response.answers[0].rdata.minimum, 3600)
> 
> 
> class TestDNSUpdates(DNSTest):
>-- 
>1.9.1
>

Actions: View

Attachments on bug 10466: 9946