The Samba-Bugzilla – Attachment 9883 Details for
Bug 10577
SMB1 wildcard unlink fail can leave a retry record on the open retry queue.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
git-am fix for master, 4.1.next and 4.0.next.
0001-s3-smbd-Fix-wildcard-unlink-to-fail-if-we-get-an-err.patch (text/plain), 961 bytes, created by
Jeremy Allison
on 2014-04-30 00:09:21 UTC
(
hide
)
Description:
git-am fix for master, 4.1.next and 4.0.next.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2014-04-30 00:09:21 UTC
Size:
961 bytes
patch
obsolete
>From f831c48bc8724c5084879f21b0b57f6a38166aa6 Mon Sep 17 00:00:00 2001 >From: Jeremy Allison <jra@samba.org> >Date: Tue, 29 Apr 2014 16:59:55 -0700 >Subject: [PATCH] s3: smbd : Fix wildcard unlink to fail if we get an error > rather than trying to continue. > >This can break smbd if we end up leaving a SHARING_VIOLATION >retry record on the queue. > >Signed-off-by: Jeremy Allison <jra@samba.org> >--- > source3/smbd/reply.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c >index da59ca7..f737d74 100644 >--- a/source3/smbd/reply.c >+++ b/source3/smbd/reply.c >@@ -2909,9 +2909,10 @@ NTSTATUS unlink_internals(connection_struct *conn, struct smb_request *req, > > status = do_unlink(conn, req, smb_fname, dirtype); > if (!NT_STATUS_IS_OK(status)) { >+ TALLOC_FREE(dir_hnd); > TALLOC_FREE(frame); > TALLOC_FREE(talloced); >- continue; >+ goto out; > } > > count++; >-- >1.9.1.423.g4596e3a >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=9883">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Flags:
vl
:
review+
obnox
:
review+
Actions:
View
Attachments on
bug 10577
: 9883