Attachment 9844 Details for Bug 10547 – patch for 4.1, cherry-picked from master

[patch] patch for 4.1, cherry-picked from master

bug-10547.v4-1-test.patch (text/plain), 1.26 KB, created by Michael Adam on 2014-04-11 10:30:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Adam

Created: 2014-04-11 10:30:30 UTC

Size: 1.26 KB

patch

obsolete

>From 040bb2eeba4a6c6c29f9cb709b27c1a26396716d Mon Sep 17 00:00:00 2001
>From: Abhidnya Joshi <achirmul@in.ibm.com>
>Date: Fri, 25 Oct 2013 07:06:01 +0200
>Subject: [PATCH] idmap_autorid: fix failure in reverse lookup if ID is from
> domain range index #0
>
>Domain range index #0 is not included in the database record.
>So in this special case we only have the SID, not SID#IDX...
>
>Signed-off-by: Abhidnya Joshi <achirmul@in.ibm.com>
>Reviewed-by: Michael Adam <obnox@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>(cherry picked from commit ebc9ff616fefbf10b31e4e097f28fa17a1abc2f8)
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=10547
>---
> source3/winbindd/idmap_autorid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/winbindd/idmap_autorid.c b/source3/winbindd/idmap_autorid.c
>index 391a314..57d952e 100644
>--- a/source3/winbindd/idmap_autorid.c
>+++ b/source3/winbindd/idmap_autorid.c
>@@ -379,7 +379,7 @@ static NTSTATUS idmap_autorid_id_to_sid(struct autorid_global_config *cfg,
> 		map->status = ID_UNKNOWN;
> 		return NT_STATUS_OK;
> 	}
>-	if (q != NULL)
>+	if ((q != NULL) && (*q != '\0'))
> 		if (sscanf(q+1, "%"SCNu32, &domain_range_index) != 1) {
> 			DEBUG(10, ("Domain range index not found, "
> 				   "ignoring mapping request\n"));
>-- 
>1.8.3.2
>

Flags:

vl: review+
metze: review+
obnox: review+

Actions: View

Attachments on bug 10547: 9844