Attachment 9798 Details for Bug 10504 – v4-0-test and v4-1-test patch

[patch] v4-0-test and v4-1-test patch

0001-lsa.idl-define-lsa.ForestTrustCollisionInfo-and-Fore.patch (text/plain), 1.66 KB, created by Alexander Bokovoy on 2014-03-24 11:49:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alexander Bokovoy

Created: 2014-03-24 11:49:12 UTC

Size: 1.66 KB

patch

obsolete

>From 101c93f1e54095f8e115e33a66ec1127ead207da Mon Sep 17 00:00:00 2001
>From: Alexander Bokovoy <ab@samba.org>
>Date: Tue, 18 Mar 2014 19:41:38 +0200
>Subject: [PATCH] lsa.idl: define lsa.ForestTrustCollisionInfo and
> ForestTrustCollisionRecord as public structs
>
>For Python bindings PIDL wants the struct to be defined as public if we
>want to use __ndr_print/pack/unpack.
>
>Define the [public] attribute to ForestTrustCollisionInfo/Record to
>allow easier debugging when there is collision in establishing a trust.
>
>This change does not affect C code as NDR functions are always
>generated, only not exposed in Python bindings.
>
>https://bugzilla.samba.org/show_bug.cgi?id=10504
>
>Signed-off-by: Alexander Bokovoy <ab@samba.org>
>Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
>
>Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
>Autobuild-Date(master): Mon Mar 24 12:44:50 CET 2014 on sn-devel-104
>
>(cherry picked from commit 59767911bded48388c27d5f9cd2ff1346a1c01a6)
>---
> librpc/idl/lsa.idl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/librpc/idl/lsa.idl b/librpc/idl/lsa.idl
>index d8f2649..80efbd5 100644
>--- a/librpc/idl/lsa.idl
>+++ b/librpc/idl/lsa.idl
>@@ -1328,14 +1328,14 @@ import "misc.idl", "security.idl";
> 		[default] uint32 flags;
> 	} lsa_ForestTrustCollisionFlags;
> 
>-	typedef struct {
>+	typedef [public] struct {
> 		uint32 index;
> 		lsa_ForestTrustCollisionRecordType type;
> 		[switch_is(type)] lsa_ForestTrustCollisionFlags flags;
> 		lsa_String name;
> 	} lsa_ForestTrustCollisionRecord;
> 
>-	typedef struct {
>+	typedef [public] struct {
> 		uint32 count;
> 		[size_is(count)] lsa_ForestTrustCollisionRecord **entries;
> 	} lsa_ForestTrustCollisionInfo;
>-- 
>1.8.5.3
>

Flags:

asn: review+

Actions: View

Attachments on bug 10504: 9788 | 9798