The Samba-Bugzilla – Attachment 9790 Details for
Bug 10506
smbreadline doesn't build with readline 6.3
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
4.0 patch cherry-picked from master
0001-smbreadline-switch-to-new-style-readline-typedef.patch (text/plain), 1.53 KB, created by
Andrew Bartlett
on 2014-03-19 21:51:09 UTC
(
hide
)
Description:
4.0 patch cherry-picked from master
Filename:
MIME Type:
Creator:
Andrew Bartlett
Created:
2014-03-19 21:51:09 UTC
Size:
1.53 KB
patch
obsolete
>From 61fdf45351c66c4552d33f2c3ee7f65fd7a74bed Mon Sep 17 00:00:00 2001 >From: Gustavo Zacarias <gustavo@zacarias.com.ar> >Date: Thu, 6 Mar 2014 18:57:40 -0300 >Subject: [PATCH] smbreadline: switch to new-style readline typedef > >Function, CPFunction, CPPFunction and VFunction typedefs are considered >old-style (deprecated) starting from readline 4.2 (circa 2001). >Compatibility typedefs have been in place up to readline 6.2 but were >removed with the 6.3 release thus causing builds to break. >Switch to the new-style specific prototyped typedef. > >Return value is unused so the callback should still be void (see >readline/input.c around line 456 in version 6.3). > >Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> >Reviewed-by: Jeremy Allison <jra@samba.org> >Reviewed-by: Andrew Bartlett <abartlet@samba.org> > >Autobuild-User(master): Jeremy Allison <jra@samba.org> >Autobuild-Date(master): Thu Mar 13 00:21:47 CET 2014 on sn-devel-104 > >(cherry picked from commit 29d779c7029f89e530994c45ae065707ffd62c43) >--- > libcli/smbreadline/smbreadline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/libcli/smbreadline/smbreadline.c b/libcli/smbreadline/smbreadline.c >index cff25a7..80e10b0 100644 >--- a/libcli/smbreadline/smbreadline.c >+++ b/libcli/smbreadline/smbreadline.c >@@ -141,7 +141,7 @@ char *smb_readline(const char *prompt, void (*callback)(void), > > #if HAVE_DECL_RL_EVENT_HOOK > if (callback) >- rl_event_hook = (Function *)callback; >+ rl_event_hook = (rl_hook_func_t *)callback; > #endif > ret = readline(prompt); > if (ret && *ret) >-- >1.9.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
jra
:
review+
Actions:
View
Attachments on
bug 10506
: 9790 |
9791