The Samba-Bugzilla – Attachment 9732 Details for
Bug 10474
The spoolssd tries to register at epmd and fails if epmd is not configured.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
v4-0-test and v4-1-test patch
0001-s3-spoolssd-Don-t-register-spoolssd-if-epmd-is-not-r.patch (text/plain), 2.73 KB, created by
Andreas Schneider
on 2014-02-27 18:24:54 UTC
(
hide
)
Description:
v4-0-test and v4-1-test patch
Filename:
MIME Type:
Creator:
Andreas Schneider
Created:
2014-02-27 18:24:54 UTC
Size:
2.73 KB
patch
obsolete
>From 93830e7268c9288d2b5d76feb2f3854133c19af0 Mon Sep 17 00:00:00 2001 >From: Andreas Schneider <asn@samba.org> >Date: Thu, 27 Feb 2014 09:58:27 +0100 >Subject: [PATCH] s3-spoolssd: Don't register spoolssd if epmd is not running. > >https://bugzilla.samba.org/show_bug.cgi?id=10474 > >Signed-off-by: Andreas Schneider <asn@samba.org> >Reviewed-by: Volker Lendecke <vl@samba.org> >(cherry picked from commit 562ade624a78a11a5af0f26b04df93d76d6166bd) >--- > source3/printing/spoolssd.c | 39 ++++++++++++++++++++++----------------- > 1 file changed, 22 insertions(+), 17 deletions(-) > >diff --git a/source3/printing/spoolssd.c b/source3/printing/spoolssd.c >index bb043bd..55aa9c7 100644 >--- a/source3/printing/spoolssd.c >+++ b/source3/printing/spoolssd.c >@@ -31,6 +31,7 @@ > #include "librpc/gen_ndr/srv_spoolss.h" > #include "rpc_server/rpc_server.h" > #include "rpc_server/rpc_ep_register.h" >+#include "rpc_server/rpc_config.h" > #include "rpc_server/spoolss/srv_spoolss_nt.h" > #include "librpc/rpc/dcerpc_ep.h" > #include "lib/server_prefork.h" >@@ -627,6 +628,7 @@ static char *get_bq_logfile(void) > pid_t start_spoolssd(struct tevent_context *ev_ctx, > struct messaging_context *msg_ctx) > { >+ enum rpc_service_mode_e epm_mode = rpc_epmapper_mode(); > struct rpc_srv_callbacks spoolss_cb; > struct dcerpc_binding_vector *v; > TALLOC_CTX *mem_ctx; >@@ -772,25 +774,28 @@ pid_t start_spoolssd(struct tevent_context *ev_ctx, > exit(1); > } > >- status = dcerpc_binding_vector_new(mem_ctx, &v); >- if (!NT_STATUS_IS_OK(status)) { >- DEBUG(0, ("Failed to create binding vector (%s)\n", >- nt_errstr(status))); >- exit(1); >- } >+ if (epm_mode != RPC_SERVICE_MODE_DISABLED && >+ (lp_parm_bool(-1, "rpc_server", "register_embedded_np", false))) { >+ status = dcerpc_binding_vector_new(mem_ctx, &v); >+ if (!NT_STATUS_IS_OK(status)) { >+ DEBUG(0, ("Failed to create binding vector (%s)\n", >+ nt_errstr(status))); >+ exit(1); >+ } > >- status = dcerpc_binding_vector_add_np_default(&ndr_table_spoolss, v); >- if (!NT_STATUS_IS_OK(status)) { >- DEBUG(0, ("Failed to add np to binding vector (%s)\n", >- nt_errstr(status))); >- exit(1); >- } >+ status = dcerpc_binding_vector_add_np_default(&ndr_table_spoolss, v); >+ if (!NT_STATUS_IS_OK(status)) { >+ DEBUG(0, ("Failed to add np to binding vector (%s)\n", >+ nt_errstr(status))); >+ exit(1); >+ } > >- status = rpc_ep_register(ev_ctx, msg_ctx, &ndr_table_spoolss, v); >- if (!NT_STATUS_IS_OK(status)) { >- DEBUG(0, ("Failed to register spoolss endpoint! (%s)\n", >- nt_errstr(status))); >- exit(1); >+ status = rpc_ep_register(ev_ctx, msg_ctx, &ndr_table_spoolss, v); >+ if (!NT_STATUS_IS_OK(status)) { >+ DEBUG(0, ("Failed to register spoolss endpoint! (%s)\n", >+ nt_errstr(status))); >+ exit(1); >+ } > } > > talloc_free(mem_ctx); >-- >1.8.5.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
vl
:
review+
asn
:
review?
(
gd
)
Actions:
View
Attachments on
bug 10474
: 9732