The Samba-Bugzilla – Attachment 9612 Details for
Bug 10398
Segfault in replmd_check_urgent_objectclass due to objectClass missing on deleted object
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
0001-Improve-objectClass-validation.patch
0001-Improve-objectClass-validation.patch (text/plain), 1.51 KB, created by
Arvid Requate
on 2014-01-23 12:24:50 UTC
(
hide
)
Description:
0001-Improve-objectClass-validation.patch
Filename:
MIME Type:
Creator:
Arvid Requate
Created:
2014-01-23 12:24:50 UTC
Size:
1.51 KB
patch
obsolete
>From 7fad73b0b58b45b7fc6ff493b0c0aab8e0b2deff Mon Sep 17 00:00:00 2001 >From: Arvid Requate <requate@univention.de> >Date: Thu, 23 Jan 2014 13:16:20 +0100 >Subject: [PATCH] Improve objectClass validation > >--- > source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > >diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c >index 3af0caa..ddbff8b 100644 >--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c >+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c >@@ -1081,6 +1081,12 @@ static int replmd_add(struct ldb_module *module, struct ldb_request *req) > replmd_ldb_message_sort(msg, ac->schema); > > objectclass_el = ldb_msg_find_element(msg, "objectClass"); >+ if (!objectclass_el) { >+ DEBUG(0,(__location__ ": objectClass missing on %s\n", >+ ldb_dn_get_linearized(msg->dn))); >+ talloc_free(ac); >+ return LDB_ERR_OPERATIONS_ERROR; >+ } > is_urgent = replmd_check_urgent_objectclass(objectclass_el, > REPL_URGENT_ON_CREATE); > >@@ -1432,7 +1438,10 @@ static int replmd_update_rpmd(struct ldb_module *module, > } > > objectclass_el = ldb_msg_find_element(res->msgs[0], "objectClass"); >- if (is_urgent && replmd_check_urgent_objectclass(objectclass_el, >+ if (!objectclass_el) { >+ DEBUG(0,(__location__ ": objectClass missing on %s\n", >+ ldb_dn_get_linearized(msg->dn))); >+ } else if (is_urgent && replmd_check_urgent_objectclass(objectclass_el, > situation)) { > *is_urgent = true; > } >-- >1.8.5.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 10398
:
9610
|
9611
|
9612
|
9729
|
9737
|
10088
|
10094