The Samba-Bugzilla – Attachment 958 Details for
Bug 2323
reply_sesssetup_and_X pulling wrong length password off wire?
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch.
look (text/plain), 814 bytes, created by
Jeremy Allison
on 2005-02-08 18:49:52 UTC
(
hide
)
Description:
Proposed patch.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2005-02-08 18:49:52 UTC
Size:
814 bytes
patch
obsolete
>Index: smbd/sesssetup.c >=================================================================== >--- smbd/sesssetup.c (revision 5283) >+++ smbd/sesssetup.c (working copy) >@@ -755,10 +755,10 @@ > pstring pass; > BOOL unic=SVAL(inbuf, smb_flg2) & FLAGS2_UNICODE_STRINGS; > >- if ((ra_type == RA_WINNT) && (passlen2 == 0) && unic && passlen1) { >- /* NT4.0 stuffs up plaintext unicode password lengths... */ >- srvstr_pull(inbuf, pass, smb_buf(inbuf) + 1, >- sizeof(pass), passlen1, STR_TERMINATE); >+ if (unic && (passlen2 == 0) && passlen1) { >+ /* Only a ascii plaintext password was sent. */ >+ srvstr_pull(inbuf, pass, smb_buf(inbuf), sizeof(pass), >+ passlen1, STR_TERMINATE|STR_ASCII); > } else { > srvstr_pull(inbuf, pass, smb_buf(inbuf), > sizeof(pass), unic ? passlen2 : passlen1,
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=958">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 2323
:
954
|
955
| 958