The Samba-Bugzilla – Attachment 9505 Details for
Bug 10300
fail authentication if user isn't member of *any* require_membership_of specified groups
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch from master with fixed bug ID and adjusted path, applies to 3.3
0001-fail-authentication-for-single-group-name-which-cann_33t.patch (text/plain), 1.40 KB, created by
David Disseldorp
on 2013-12-05 11:40:11 UTC
(
hide
)
Description:
Patch from master with fixed bug ID and adjusted path, applies to 3.3
Filename:
MIME Type:
Creator:
David Disseldorp
Created:
2013-12-05 11:40:11 UTC
Size:
1.40 KB
patch
obsolete
>From 1ac2ae5eabf17ee5231e28a7dd01b01de499d438 Mon Sep 17 00:00:00 2001 >From: Noel Power <noel.power@suse.com> >Date: Wed, 16 Oct 2013 16:30:55 +0100 >Subject: [PATCH] fail authentication for single group name which cannot be > converted to sid > >furthermore if more than one name is supplied and no sid is converted >then also fail. > >Bug: https://bugzilla.samba.org/show_bug.cgi?id=10300 > >Signed-off-by: Noel Power <noel.power@suse.com> >Reviewed-by: Andreas Schneider <asn@samba.org> >Reviewed-by: David Disseldorp <ddiss@samba.org> >[ddiss@samba.org: fixed incorrect bugzilla tag I added to master commit] >--- > source/nsswitch/pam_winbind.c | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/source/nsswitch/pam_winbind.c b/source/nsswitch/pam_winbind.c >index 5dccba1..7c069d3 100644 >--- a/source/nsswitch/pam_winbind.c >+++ b/source/nsswitch/pam_winbind.c >@@ -1092,6 +1092,12 @@ static bool winbind_name_list_to_sid_string_list(struct pwb_context *ctx, > _make_remark_format(ctx, PAM_TEXT_INFO, _("Cannot convert group %s " > "to sid, please contact your administrator to see " > "if group %s is valid."), search_location, search_location); >+ >+ /* If no valid groups were converted we should fail outright */ >+ if (name_list != NULL && strlen(sid_list_buffer) == 0) { >+ result = false; >+ goto out; >+ } > /* > * The lookup of the last name failed.. > * It results in require_member_of_sid ends with ',' >-- >1.8.1.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
asn
:
review+
Actions:
View
Attachments on
bug 10300
:
9495
|
9496
|
9499
| 9505 |
9506
|
9507