Attachment 9413 Details for Bug 10264 – patch for master

[patch] patch for master

out (text/plain), 1.31 KB, created by Guenther Deschner on 2013-11-13 14:23:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guenther Deschner

Created: 2013-11-13 14:23:23 UTC

Size: 1.31 KB

patch

obsolete

>From 1db6ae27ecb15787afaef0478784a6158478189e Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
>Date: Wed, 13 Nov 2013 15:10:33 +0100
>Subject: [PATCH] s3-winbindd: Fix #10264, cache_traverse_validate_fn failure
> for NDR cache entries.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>We need to increase the keysize limit for NDR queries. A wbint_LookupSids query
>for just 20 sids already hits the older limit.
>
>Guenther
>
>https://bugzilla.samba.org/show_bug.cgi?id=10264
>Signed-off-by: GÃ¼nther Deschner <gd@samba.org>
>---
> source3/winbindd/winbindd_cache.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
>index 7252927..fe05759 100644
>--- a/source3/winbindd/winbindd_cache.c
>+++ b/source3/winbindd/winbindd_cache.c
>@@ -4064,7 +4064,8 @@ static int cache_traverse_validate_fn(TDB_CONTEXT *the_tdb, TDB_DATA kbuf, TDB_D
> 	struct tdb_validation_status *v_state = (struct tdb_validation_status *)state;
> 
> 	/* Paranoia check. */
>-	if (strncmp("UA/", (const char *)kbuf.dptr, 3) == 0) {
>+	if (strncmp("UA/", (const char *)kbuf.dptr, 3) == 0 ||
>+	    strncmp("NDR/", (const char *)kbuf.dptr, 4) == 0) {
> 		max_key_len = 1024 * 1024;
> 	}
> 	if (kbuf.dsize > max_key_len) {
>-- 
>1.8.3.1
>

Flags:

obnox: review+

Actions: View

Attachments on bug 10264: 9413