The Samba-Bugzilla – Attachment 9292 Details for
Bug 10211
Log lines sent to files should not human-readable-ize numbers, ever
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Make end-of-sync log line not use commas if logfile_name!=NULL
logfile_comma_fix.patch (text/plain), 1009 bytes, created by
Tobias Klausmann
on 2013-10-16 09:01:43 UTC
(
hide
)
Description:
Make end-of-sync log line not use commas if logfile_name!=NULL
Filename:
MIME Type:
Creator:
Tobias Klausmann
Created:
2013-10-16 09:01:43 UTC
Size:
1009 bytes
patch
obsolete
>diff --git a/log.c b/log.c >index 34a013b..be86d12 100644 >--- a/log.c >+++ b/log.c >@@ -23,6 +23,8 @@ > #include "itypes.h" > #include "inums.h" > >+#include <inttypes.h> >+ > extern int dry_run; > extern int am_daemon; > extern int am_server; >@@ -873,10 +875,19 @@ void log_delete(const char *fname, int mode) > void log_exit(int code, const char *file, int line) > { > if (code == 0) { >- rprintf(FLOG,"sent %s bytes received %s bytes total size %s\n", >- comma_num(stats.total_written), >- comma_num(stats.total_read), >- comma_num(stats.total_size)); >+ if (logfile_name != NULL) { >+ rprintf(FLOG, >+ "sent %.0f bytes received %.0f bytes total size %.0f\n", >+ (double)stats.total_written, >+ (double)stats.total_read, >+ (double)stats.total_size); >+ } else { >+ rprintf(FLOG, >+ "sent %s bytes received %s bytes total size %s\n", >+ comma_num(stats.total_written), >+ comma_num(stats.total_read), >+ comma_num(stats.total_size)); >+ } > } else if (am_server != 2) { > const char *name; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 10211
: 9292