Attachment 9262 Details for Bug 10187 – git-am fix for 4.1.0, 4.0.next. 3.6.next

[patch] git-am fix for 4.1.0, 4.0.next. 3.6.next

0001-Fix-bug-10187-Missing-talloc_free-can-leak-stackfram.patch (text/plain), 1.08 KB, created by Jeremy Allison on 2013-10-09 17:17:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2013-10-09 17:17:01 UTC

Size: 1.08 KB

patch

obsolete

>From 0de6282e00e1052d8facf6bcad69f2b8fa547895 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Tue, 8 Oct 2013 15:01:38 -0700
>Subject: [PATCH] Fix bug #10187 - Missing talloc_free can leak stackframe in
> error path.
>
>Fix error path.
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: David Disseldorp <ddiss@samba.org>
>
>Autobuild-User(master): David Disseldorp <ddiss@samba.org>
>Autobuild-Date(master): Wed Oct  9 03:50:56 CEST 2013 on sn-devel-104
>---
> source3/winbindd/winbindd_msrpc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/source3/winbindd/winbindd_msrpc.c b/source3/winbindd/winbindd_msrpc.c
>index e86838c..61447d3 100644
>--- a/source3/winbindd/winbindd_msrpc.c
>+++ b/source3/winbindd/winbindd_msrpc.c
>@@ -944,8 +944,9 @@ static NTSTATUS msrpc_trusted_domains(struct winbindd_domain *domain,
> 	}
> 
> 	status = cm_connect_lsa(domain, tmp_ctx, &lsa_pipe, &lsa_policy);
>-	if (!NT_STATUS_IS_OK(status))
>-		return status;
>+	if (!NT_STATUS_IS_OK(status)) {
>+		goto done;
>+	}
> 
> 	status = rpc_trusted_domains(tmp_ctx,
> 				     lsa_pipe,
>-- 
>1.8.4
>

Flags:

ddiss: review+

Actions: View

Attachments on bug 10187: 9262