Attachment 8860 Details for Bug 9854 – Patch for master

[patch] Patch for master

look (text/plain), 1.41 KB, created by Volker Lendecke on 2013-05-07 10:40:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2013-05-07 10:40:58 UTC

Size: 1.41 KB

patch

obsolete

>From 3bdd21153254d40dfa555de9e2a94c89728fb325 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Tue, 7 May 2013 12:39:16 +0200
>Subject: [PATCH] winbind: Fix bug 9854 -- NULL pointer dereference
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>---
> source3/winbindd/winbindd_cache.c |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
>index 86f15c2..7252927 100644
>--- a/source3/winbindd/winbindd_cache.c
>+++ b/source3/winbindd/winbindd_cache.c
>@@ -944,7 +944,7 @@ static void wcache_save_name_to_sid(struct winbindd_domain *domain,
> 	if (!centry)
> 		return;
> 
>-	if (domain_name[0] == '\0') {
>+	if ((domain_name == NULL) || (domain_name[0] == '\0')) {
> 		struct winbindd_domain *mydomain =
> 			find_domain_from_sid_noinit(sid);
> 		if (mydomain != NULL) {
>@@ -972,7 +972,7 @@ static void wcache_save_sid_to_name(struct winbindd_domain *domain, NTSTATUS sta
> 	if (!centry)
> 		return;
> 
>-	if (domain_name[0] == '\0') {
>+	if ((domain_name == NULL) || (domain_name[0] == '\0')) {
> 		struct winbindd_domain *mydomain =
> 			find_domain_from_sid_noinit(sid);
> 		if (mydomain != NULL) {
>@@ -1810,7 +1810,7 @@ NTSTATUS wcache_name_to_sid(struct winbindd_domain *domain,
> 		return NT_STATUS_NO_MEMORY;
> 	}
> 
>-	if (domain_name[0] == '\0') {
>+	if ((domain_name == NULL) || (domain_name[0] == '\0')) {
> 		domain_name = domain->name;
> 	}
> 
>-- 
>1.7.9.5
>

Flags:

asn: review+

Actions: View

Attachments on bug 9854: 8850 | 8855 | 8856 | 8857 | 8860 | 8867 | 8868