The Samba-Bugzilla – Attachment 8749 Details for
Bug 9779
add UPN enumeration to passdb internal API
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix wafsamba for creating non-empty ABI files in specific case for PASSDB
0001-wafsamba-fix-samba_abi-for-default-catch-all-case.patch (text/plain), 1.74 KB, created by
Alexander Bokovoy
on 2013-04-10 08:27:38 UTC
(
hide
)
Description:
fix wafsamba for creating non-empty ABI files in specific case for PASSDB
Filename:
MIME Type:
Creator:
Alexander Bokovoy
Created:
2013-04-10 08:27:38 UTC
Size:
1.74 KB
patch
obsolete
>From bc7060261e5ad4db03d49414f8d3910ae231b79f Mon Sep 17 00:00:00 2001 >From: Alexander Bokovoy <ab@samba.org> >Date: Wed, 3 Apr 2013 15:52:06 +0300 >Subject: [PATCH 1/4] wafsamba: fix samba_abi for default catch-all case > >Only filter out the symbol when positive match was not found and there is >negative match. > >ABI signature file generator worked incorrectly for cases when mixture of >positive and negative matches were provided. This resulted in generating empty >signature file for libpdb since there was no catch-all positive match anymore. > >Commit 9ba44cc610426fb558b49aa9680b5bdf55c29082 removed explicit '*' positive >match and corresponding vscript generator adds '*' by default if global match >list is empty, so this commit introduces feature parity into signature >generator. > >Reviewed-by: Andreas Schneider <asn@samba.org> >--- > buildtools/wafsamba/samba_abi.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/buildtools/wafsamba/samba_abi.py b/buildtools/wafsamba/samba_abi.py >index 488dab8..76acd00 100644 >--- a/buildtools/wafsamba/samba_abi.py >+++ b/buildtools/wafsamba/samba_abi.py >@@ -50,13 +50,15 @@ def parse_sigs(sigs, abi_match): > sa = s.split(':') > if abi_match: > matched = False >+ negative = False > for p in abi_match: > if p[0] == '!' and fnmatch.fnmatch(sa[0], p[1:]): >+ negative = True > break > elif fnmatch.fnmatch(sa[0], p): > matched = True > break >- if not matched: >+ if (not matched) and negative: > continue > Logs.debug("%s -> %s" % (sa[1], normalise_signature(sa[1]))) > ret[sa[0]] = normalise_signature(sa[1]) >-- >1.8.1.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
asn
:
review+
Actions:
View
Attachments on
bug 9779
: 8749 |
8750
|
8751
|
8752