The Samba-Bugzilla – Attachment 8731 Details for
Bug 9768
Upgrade failures to connect to ldap do not error out cleanly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
path for master (for testing)
0001-python-samba-tool-domain-classicupgrade-Make-failure.patch (text/plain), 1.12 KB, created by
Andrew Bartlett
on 2013-04-05 04:28:21 UTC
(
hide
)
Description:
path for master (for testing)
Filename:
MIME Type:
Creator:
Andrew Bartlett
Created:
2013-04-05 04:28:21 UTC
Size:
1.12 KB
patch
obsolete
>From c494607d6af22e4f79d5121adb06889ee5a2521a Mon Sep 17 00:00:00 2001 >From: Andrew Bartlett <abartlet@samba.org> >Date: Fri, 5 Apr 2013 15:23:20 +1100 >Subject: [PATCH] python-samba-tool domain classicupgrade: Make failure to > connect directly to the LDAP backend fatal > >This is better than failing just a little further down the stack with a useless error >about use-before-set. > >Andrew Bartlett >--- > python/samba/upgrade.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/python/samba/upgrade.py b/python/samba/upgrade.py >index 8371224..af854ef 100644 >--- a/python/samba/upgrade.py >+++ b/python/samba/upgrade.py >@@ -791,7 +791,7 @@ Please fix this account before attempting to upgrade again > try: > ldb_object = Ldb(url, credentials=creds) > except ldb.LdbError, e: >- logger.warning("Could not open ldb connection to %s, the error message is: %s", url, e) >+ raise ProvisiongError("Could not open ldb connection to %s, the error message is: %s" % (url, e)) > else: > break > logger.info("Exporting posix attributes") >-- >1.7.11.7 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 9768
: 8731