From c494607d6af22e4f79d5121adb06889ee5a2521a Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Fri, 5 Apr 2013 15:23:20 +1100 Subject: [PATCH] python-samba-tool domain classicupgrade: Make failure to connect directly to the LDAP backend fatal This is better than failing just a little further down the stack with a useless error about use-before-set. Andrew Bartlett --- python/samba/upgrade.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/samba/upgrade.py b/python/samba/upgrade.py index 8371224..af854ef 100644 --- a/python/samba/upgrade.py +++ b/python/samba/upgrade.py @@ -791,7 +791,7 @@ Please fix this account before attempting to upgrade again try: ldb_object = Ldb(url, credentials=creds) except ldb.LdbError, e: - logger.warning("Could not open ldb connection to %s, the error message is: %s", url, e) + raise ProvisiongError("Could not open ldb connection to %s, the error message is: %s" % (url, e)) else: break logger.info("Exporting posix attributes") -- 1.7.11.7