From 2daf5b123a2eefd004e28bb66d3d75c8021e1dc3 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 20 Feb 2013 09:41:55 +0100 Subject: [PATCH 1/2] winbind: Don't leak memory on return. Reviewed-by: Alexander Bokovoy --- source3/winbindd/winbindd_cm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c index 28583fd..9cb3717 100644 --- a/source3/winbindd/winbindd_cm.c +++ b/source3/winbindd/winbindd_cm.c @@ -1023,6 +1023,9 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain, if ( !(*cli)->domain[0] ) { result = cli_set_domain((*cli), domain->name); if (!NT_STATUS_IS_OK(result)) { + SAFE_FREE(ipc_username); + SAFE_FREE(ipc_domain); + SAFE_FREE(ipc_password); return result; } } -- 1.8.1.4 From 0669ea382b0798a2873bc6b1d4fcfb5db86b0e8f Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 20 Feb 2013 09:51:43 +0100 Subject: [PATCH 2/2] winbind: Don't leak centry memory. Reviewed-by: Alexander Bokovoy --- source3/winbindd/winbindd_cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c index ea503e1..81b9b17 100644 --- a/source3/winbindd/winbindd_cache.c +++ b/source3/winbindd/winbindd_cache.c @@ -2130,6 +2130,7 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain, } else { /* something's definitely wrong */ result = centry->status; + centry_free(centry); goto error; } -- 1.8.1.4