The Samba-Bugzilla – Attachment 8541 Details for
Bug 9519
Samba returns unexpected error on SMB posix open
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
this patch masks the flag ... but I think it is too aggressive a warning and makes it looks like a kernel bug rather than an app bug.
warn-on-and-ignore-illegal-o_excl.patch (text/plain), 701 bytes, created by
Steve French
on 2013-02-12 02:32:45 UTC
(
hide
)
Description:
this patch masks the flag ... but I think it is too aggressive a warning and makes it looks like a kernel bug rather than an app bug.
Filename:
MIME Type:
Creator:
Steve French
Created:
2013-02-12 02:32:45 UTC
Size:
701 bytes
patch
obsolete
>diff --git a/fs/cifs/file.c b/fs/cifs/file.c >index 8ea6ca5..c4860cf 100644 >--- a/fs/cifs/file.c >+++ b/fs/cifs/file.c >@@ -72,10 +72,15 @@ static u32 cifs_posix_convert_flags(unsigned int flags) > else if ((flags & O_ACCMODE) == O_RDWR) > posix_flags = SMB_O_RDWR; > >- if (flags & O_CREAT) >+ if (flags & O_CREAT) { > posix_flags |= SMB_O_CREAT; >- if (flags & O_EXCL) >- posix_flags |= SMB_O_EXCL; >+ if (flags & O_EXCL) >+ posix_flags |= SMB_O_EXCL; >+ } else if (flags & O_EXCL) >+ WARN_ONCE(1, "Application has incorrectly set O_EXCL flag " >+ "without O_CREAT on file open, ignoring O_EXCL"); >+ >+ > if (flags & O_TRUNC) > posix_flags |= SMB_O_TRUNC; > /* be safe and imply O_SYNC for O_DSYNC */
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=8541">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 9519
:
8365
|
8366
| 8541 |
8542
|
8544