The Samba-Bugzilla – Attachment 8532 Details for
Bug 9637
Renaming directories as guest user in security share mode doesn't work.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
v3-6-test patch
0001-s3-smbd-Avoid-acl-check-for-security-share-mode-gues.patch (text/plain), 1.29 KB, created by
Andreas Schneider
on 2013-02-06 13:03:43 UTC
(
hide
)
Description:
v3-6-test patch
Filename:
MIME Type:
Creator:
Andreas Schneider
Created:
2013-02-06 13:03:43 UTC
Size:
1.29 KB
patch
obsolete
>From 2398d2032122da24a306cc15bb0330ff1c0ce8a7 Mon Sep 17 00:00:00 2001 >From: Andreas Schneider <asn@samba.org> >Date: Wed, 6 Feb 2013 13:55:39 +0100 >Subject: [PATCH] s3-smbd: Avoid acl check for security share mode guest > connections. > >This fixes guest only shares were you're not able to rename directories. > >Signed-off-by: Andreas Schneider <asn@samba.org> >--- > source3/smbd/file_access.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/source3/smbd/file_access.c b/source3/smbd/file_access.c >index 1f5ee4f..91f58d2 100644 >--- a/source3/smbd/file_access.c >+++ b/source3/smbd/file_access.c >@@ -19,6 +19,7 @@ > */ > > #include "includes.h" >+#include "auth.h" > #include "system/filesys.h" > #include "../libcli/security/security.h" > #include "../librpc/gen_ndr/ndr_security.h" >@@ -93,13 +94,17 @@ bool can_delete_file_in_directory(connection_struct *conn, > char *dname = NULL; > struct smb_filename *smb_fname_parent = NULL; > NTSTATUS status; >+ int snum = SNUM(conn); > bool ret; > > if (!CAN_WRITE(conn)) { > return False; > } > >- if (!lp_acl_check_permissions(SNUM(conn))) { >+ if (!lp_acl_check_permissions(snum) || >+ (lp_security() == SEC_SHARE && >+ lp_guest_ok(snum) && >+ conn->session_info->guest)) { > /* This option means don't check. */ > return true; > } >-- >1.8.1.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
vl
:
review+
jra
:
review-
Actions:
View
Attachments on
bug 9637
:
8532
|
8540
|
8591
|
8609
|
8610