Attachment 8343 Details for Bug 7824 – Patch cherry-picked from master

[patch] Patch cherry-picked from master

0001-s3-Don-t-use-as-needed.patch (text/plain), 2.15 KB, created by Karolin Seeger on 2012-12-12 08:55:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Karolin Seeger

Created: 2012-12-12 08:55:02 UTC

Size: 2.15 KB

patch

obsolete

>From 7a94c4a3055066a33a577cd28b53fe04436e1c5f Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Sun, 18 Jul 2010 11:56:17 +0200
>Subject: [PATCH] s3: Don't use as-needed
>
>This is just broken. RHEL5 can't deal with it, FreeBSD8 is broken with it, and
>who knows what other platforms are broken. I can rather live with a system that
>links in a bit too much than a system that does not work at all.
>(cherry picked from commit b9835a1f9d8b81e4121a01a190dffaefe67cbe5c)
>
>Fix bug #7824 - .... as-needed again.
>---
> source3/configure.in |   33 ---------------------------------
> 1 files changed, 0 insertions(+), 33 deletions(-)
>
>diff --git a/source3/configure.in b/source3/configure.in
>index 9d7fb5d..904d264 100644
>--- a/source3/configure.in
>+++ b/source3/configure.in
>@@ -1730,39 +1730,6 @@ fi
> 
> AC_MSG_RESULT($BLDSHARED)
> 
>-saved_before_as_needed_ldflags="$LDFLAGS"
>-for flags in "-Wl,--as-needed" "-Wl,-z,ignore" "-z ignore" ; do
>-	saved_ldflags="$LDFLAGS"
>-	AC_MSG_CHECKING([if $flags works])
>-	LDFLAGS="$flags $saved_ldflags"
>-	AC_TRY_LINK([],[],
>-		[AC_MSG_RESULT([yes])
>-		LD_AS_NEEDED_FLAG=$flags
>-		ld_as_needed_flag_found=yes],
>-		AC_MSG_RESULT([no]))
>-	LDFLAGS="$LD_AS_NEEDED_FLAG $saved_ldflags"
>-	test x"$ld_as_needed_flag_found" = xyes && break
>-done
>-
>-# check if we have to disable LD_AS_NEEDED_FLAG:
>-# On some systems for a veriety of reasons linking with
>-# -Wl,--as-needed -lreadline -lncurses fails
>-# we have to retest, if these combination is detected before.
>-# Bugzilla #7209
>-
>-if test x$ac_cv_lib_readline_rl_callback_handler_install = xyes ; then
>-	if test x$ld_as_needed_flag_found = xyes ; then
>-		AC_MSG_CHECKING([if $LD_AS_NEEDED_FLAG works with readline])
>-		# try if check no fails
>-		save_LIBS=$LIBS
>-		LIBS="$LIBS $TERMLIBS"
>-		AC_TRY_LINK([], [rl_callback_handler_install();], [AC_MSG_RESULT([yes])],[ AC_MSG_RESULT([no]); LDFLAGS="$saved_before_as_needed_ldflags"])
>-		LIBS="$save_LIBS"
>-        fi
>-fi
>-
>-
>-
> # for historical reasons almost all linkers don't complain about unresolved
> # symbols in shared libs. Except for the internal samba modules we want to get
> # errors when we produce a shared lib with unresolved symbols. On some
>-- 
>1.7.7
>

Actions: View

Attachments on bug 7824: 8343