Attachment 8237 Details for Bug 9436 – v3-6-test patch

[patch] v3-6-test patch

0001-BUG-9436-Fix-leaking-sockets-of-SMB-connections-to-a.patch (text/plain), 1.19 KB, created by Andreas Schneider on 2012-11-28 17:28:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2012-11-28 17:28:14 UTC

Size: 1.19 KB

patch

obsolete

>From 1e0b3989f60d1db8c5362a653733ce5e38faf0db Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Wed, 28 Nov 2012 12:53:39 +0100
>Subject: [PATCH] BUG 9436: Fix leaking sockets of SMB connections to a DC.
>
>As this is a burst of 3 unbound sockets with each try to reach a DC
>we're running out of file descriptors pretty fast. So winbind is then
>mostly spinning in an accept loop failing with EMFILE.
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Jim McDonough <jmcd@samba.org>
>
>Autobuild-User(master): Jim McDonough <jmcd@samba.org>
>Autobuild-Date(master): Wed Nov 28 17:17:21 CET 2012 on sn-devel-104
>---
> source3/winbindd/winbindd_cm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
>index 79b5839..57027eb 100644
>--- a/source3/winbindd/winbindd_cm.c
>+++ b/source3/winbindd/winbindd_cm.c
>@@ -1598,6 +1598,10 @@ static NTSTATUS cm_open_connection(struct winbindd_domain *domain,
> 
> 		result = cm_prepare_connection(domain, fd, domain->dcname,
> 			&new_conn->cli, &retry);
>+		if (!NT_STATUS_IS_OK(result)) {
>+			/* Don't leak the smb connection socket */
>+			close(fd);
>+		}
> 
> 		if (!retry)
> 			break;
>-- 
>1.8.0
>

Flags:

jmcd: review+
vl: review+

Actions: View

Attachments on bug 9436: 8235 | 8236 | 8237