From a0162d41bb849ff50e6482b939d52906a1d3c5e3 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 28 Nov 2012 12:53:39 +0100 Subject: [PATCH] BUG 9436: Fix leaking sockets of SMB connections to a DC. As this is a burst of 3 unbound sockets with each try to reach a DC we're running out of file descriptors pretty fast. So winbind is then mostly spinning in an accept loop failing with EMFILE. Signed-off-by: Andreas Schneider --- source3/winbindd/winbindd_cm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c index 79b5839..2edcd12 100644 --- a/source3/winbindd/winbindd_cm.c +++ b/source3/winbindd/winbindd_cm.c @@ -1598,6 +1598,10 @@ static NTSTATUS cm_open_connection(struct winbindd_domain *domain, result = cm_prepare_connection(domain, fd, domain->dcname, &new_conn->cli, &retry); + if (!NT_STATUS_IS_OK(result)) { + /* DON'T LEAK THE SMB CONNECTION SOCKET */ + close(fd); + } if (!retry) break; -- 1.8.0