Attachment 8055 Details for Bug 9255 – Proposed patch to fix the problem

[patch] Proposed patch to fix the problem

0006-drs-getncchanges-do-not-set-the-highestUsn-to-0.patch (text/plain), 980 bytes, created by Matthieu Patou on 2012-10-13 06:55:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthieu Patou

Created: 2012-10-13 06:55:30 UTC

Size: 980 bytes

patch

obsolete

>From 2eae16102a583c8057f9f5a089ba0e5e97fb56d0 Mon Sep 17 00:00:00 2001
>From: Matthieu Patou <mat@matws.net>
>Date: Tue, 25 Sep 2012 14:02:55 -0700
>Subject: [PATCH 06/20] drs-getncchanges: do not set the highestUsn to 0
>
>Paragraph 4.1.10.5 says that
>         if err = 0 then
>         msgOut.pNC := msgIn.pNC
>         msgOut.usnvecFrom := msgIn.usnvecFrom
>so no need to set the highestUsn to 0
>---
> source4/rpc_server/drsuapi/getncchanges.c |    1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c
>index c366eed..f65fa2c 100644
>--- a/source4/rpc_server/drsuapi/getncchanges.c
>+++ b/source4/rpc_server/drsuapi/getncchanges.c
>@@ -1016,7 +1016,6 @@ static WERROR getncchanges_repl_obj(struct drsuapi_bind_state *b_state,
> 		 drs_ObjectIdentifier_to_string(mem_ctx, ncRoot)));
> 
> 	ctr6->extended_ret = DRSUAPI_EXOP_ERR_SUCCESS;
>-	req10->highwatermark.highest_usn = 0;
> 	return WERR_OK;
> }
> 
>-- 
>1.7.9.5
>

Flags:

mat: review? (jra)
metze: review+
mat: review? (abartlet)

Actions: View

Attachments on bug 9255: 8055