The Samba-Bugzilla – Attachment 8051 Details for
Bug 9251
DsGetDomainControllerInfo returns objects of class server even if they don't have a serverreference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix the bug by adding more precises tests
0001-getdcinfo-Check-that-the-server-object-has-a-serverr.patch (text/plain), 1.62 KB, created by
Matthieu Patou
on 2012-10-13 06:39:17 UTC
(
hide
)
Description:
Fix the bug by adding more precises tests
Filename:
MIME Type:
Creator:
Matthieu Patou
Created:
2012-10-13 06:39:17 UTC
Size:
1.62 KB
patch
obsolete
>From 3dd2b804b98e232bf9f28a29577f7fdd026a228c Mon Sep 17 00:00:00 2001 >From: Matthieu Patou <mat@matws.net> >Date: Mon, 24 Sep 2012 23:12:25 -0700 >Subject: [PATCH 01/20] getdcinfo: Check that the server object has a > serverreference objects pointing to a DC object > >The problem was found by the DRSR testsuite where server objects were >created in the Site container without serverrefrence attribute >triggering error in the testsuite. >--- > source4/rpc_server/drsuapi/dcesrv_drsuapi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/source4/rpc_server/drsuapi/dcesrv_drsuapi.c b/source4/rpc_server/drsuapi/dcesrv_drsuapi.c >index 4c78738..b294e46 100644 >--- a/source4/rpc_server/drsuapi/dcesrv_drsuapi.c >+++ b/source4/rpc_server/drsuapi/dcesrv_drsuapi.c >@@ -599,7 +599,7 @@ static WERROR dcesrv_drsuapi_DsGetDomainControllerInfo_1(struct drsuapi_bind_sta > } > > ret = ldb_search(b_state->sam_ctx, mem_ctx, &res, sites_dn, LDB_SCOPE_SUBTREE, attrs, >- "objectClass=server"); >+ "(&(objectClass=server)(serverReference=*))"); > > if (ret) { > DEBUG(1, ("searching for servers in sites DN %s failed: %s\n", >@@ -630,7 +630,9 @@ static WERROR dcesrv_drsuapi_DsGetDomainControllerInfo_1(struct drsuapi_bind_sta > } > > ret = ldb_search(b_state->sam_ctx, mem_ctx, &res_account, ref_dn, >- LDB_SCOPE_BASE, attrs_account_1, "objectClass=computer"); >+ LDB_SCOPE_BASE, attrs_account_1, >+ "(&(objectClass=computer)(userAccountControl:1.2.840.113556.1.4.803:=%u)", >+ UF_SERVER_TRUST_ACCOUNT); > if (ret == LDB_SUCCESS && res_account->count == 1) { > const char *errstr; > ctr1->array[i].dns_name >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
abartlet
:
review+
Actions:
View
Attachments on
bug 9251
:
8051
|
8079