The Samba-Bugzilla – Attachment 7929 Details for
Bug 9197
Disabling printing still makes smbd create and access printer_list.tdb
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch (taken from master)
0001-s3-printing-only-do-printing_subsystem_update-when-p.patch (text/plain), 1.19 KB, created by
Christian Ambach
on 2012-09-24 05:02:12 UTC
(
hide
)
Description:
Proposed patch (taken from master)
Filename:
MIME Type:
Creator:
Christian Ambach
Created:
2012-09-24 05:02:12 UTC
Size:
1.19 KB
patch
obsolete
>From 645eb4d1ecc2b3b8af1fd84946651b47416a623b Mon Sep 17 00:00:00 2001 >From: Christian Ambach <ambi@samba.org> >Date: Sun, 23 Sep 2012 08:39:49 +0200 >Subject: [PATCH] s3:printing only do printing_subsystem_update when printing > is enabled > >no point in calling this if printing was disabled and no spoolss service was started >this hurts CTDB clusters as the smbds on the cluster nodes will fight for the single record in the TDB > >This fixes Bug 9197 - Disabling printing still makes smbd create and access printer_list.tdb >--- > source3/smbd/server.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/source3/smbd/server.c b/source3/smbd/server.c >index d53b19a..15762d8 100644 >--- a/source3/smbd/server.c >+++ b/source3/smbd/server.c >@@ -1529,7 +1529,10 @@ extern void build_options(bool screen); > > /* do a printer update now that all messaging has been set up, > * before we allow clients to start connecting */ >- printing_subsystem_update(ev_ctx, msg_ctx, false); >+ if (!lp__disable_spoolss() && >+ (rpc_spoolss_daemon() != RPC_DAEMON_DISABLED)) { >+ printing_subsystem_update(ev_ctx, msg_ctx, false); >+ } > > TALLOC_FREE(frame); > /* make sure we always have a valid stackframe */ >-- >1.7.11.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
asn
:
review+
Actions:
View
Attachments on
bug 9197
: 7929