Attachment 7878 Details for Bug 9013 – patch for 3.6 series, same code change.

[patch] patch for 3.6 series, same code change.

0001-nsswitch-fix-crash-on-null-pam-change-pw-response.patch (text/plain), 1.07 KB, created by David Disseldorp on 2012-09-11 16:59:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Disseldorp

Created: 2012-09-11 16:59:55 UTC

Size: 1.07 KB

patch

obsolete

>From e5ad657d9860bc6ad4f78b3a6413cbc7e1e91f24 Mon Sep 17 00:00:00 2001
>From: Luca Lorenzetto <lorenzetto-luca@ubuntu-it.org>
>Date: Tue, 11 Sep 2012 18:35:42 +0200
>Subject: [PATCH] nsswitch: fix crash on null pam change pw response
>
>The function _pam_winbind_change_pwd crashes due to a null value passed
>to the function strcasecmp and denies to login via graphical login
>manager. Check for a null value before doing a strcasecmp.
>
>Bug-Ubuntu: https://bugs.launchpad.net/bugs/1003296
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=9013
>---
> nsswitch/pam_winbind.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c
>index f676128..025d930 100644
>--- a/nsswitch/pam_winbind.c
>+++ b/nsswitch/pam_winbind.c
>@@ -831,7 +831,7 @@ static bool _pam_winbind_change_pwd(struct pwb_context *ctx)
> 	}
> 	_pam_log(ctx, LOG_CRIT, "Received [%s] reply from application.\n", resp->resp);
> 
>-	if (strcasecmp(resp->resp, "yes") == 0) {
>+	if ((resp->resp != NULL) && (strcasecmp(resp->resp, "yes") == 0)) {
> 		retval = true;
> 	}
> 
>-- 
>1.7.7
>

Flags:

ddiss: review+
asn: review+

Actions: View

Attachments on bug 9013: 7877 | 7878