Attachment 7877 Details for Bug 9013 – Fixes bug adding a check for a null value before calling strcasecmp

[patch] Fixes bug adding a check for a null value before calling strcasecmp

bug_lp_1003296.diff (text/plain), 1.03 KB, created by Luca 'remix_tj' Lorenzetto on 2012-09-11 09:39:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Luca 'remix_tj' Lorenzetto

Created: 2012-09-11 09:39:39 UTC

Size: 1.03 KB

patch

obsolete

>Description: Checks for null value before doing a strcasecmp, fixes LP #1003296
> The function _pam_winbind_change_pwd crashes
> due to a null value passed to the function strcasecmp and
> denies to login via graphical login manager.
> .
> samba (2:3.6.3-2ubuntu2.3) precise-proposed; urgency=low
> .
>   * nsswitch/pam_winbind.c: checks for a null value before strcasecmp, that causes
>	_pam_winbind_change_pwd to crash
>     (LP: #1003296).
>Author: Luca Lorenzetto <lorenzetto-luca@ubuntu-it.org>
>Bug-Ubuntu: https://bugs.launchpad.net/bugs/1003296
>
>---
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=9013
>Bug-Ubuntu: https://launchpad.net/bugs/1003296
>Forwarded: no
>Last-Update: 2012-09-11
>
>--- samba-3.6.3.orig/nsswitch/pam_winbind.c
>+++ samba-3.6.3/nsswitch/pam_winbind.c
>@@ -831,7 +831,7 @@ static bool _pam_winbind_change_pwd(stru
> 	}
> 	_pam_log(ctx, LOG_CRIT, "Received [%s] reply from application.\n", resp->resp);
> 
>-	if (strcasecmp(resp->resp, "yes") == 0) {
>+	if ((resp->resp != NULL) && (strcasecmp(resp->resp, "yes") == 0)) {
> 		retval = true;
> 	}
>

Flags:

ddiss: review+
asn: review+

Actions: View

Attachments on bug 9013: 7877 | 7878